fix: Don't keep bad packets in the adapter's send queues #1648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-2408 (also related to MTT-2329)
When sending a message caused an error, we would keep that message in the adapter's send queue. That's the correct behavior when the error is for a UTP send queue overflow (we want to retry sending later), but it's wrong for all other types of errors, since these are not recoverable (you can't just wait them out). This would cause the error message to be spammed endlessly on each update as the adapter tried to resend the packet.
The fix is simply to remove the packet from the adapter's send queue on non-overflow errors.
Changelog
com.unity.netcode.adapter.utp
Testing and Documentation