Skip to content

fix: Correctly dispose of everything in adapter's OnDestroy (1.0.0) #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2022
Merged

fix: Correctly dispose of everything in adapter's OnDestroy (1.0.0) #1641

merged 2 commits into from
Feb 1, 2022

Conversation

simon-lemay-unity
Copy link
Contributor

Backport of PR #1640 to release/1.0.0.

Changelog

com.unity.netcode.adapter.utp

  • Fixed: Fixed issue with native collections not all being disposed of when destroying the component without shutting it down properly. This would result in errors in the console and memory leaks.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@simon-lemay-unity simon-lemay-unity force-pushed the fix-1.0.0/adapter-ondestroy-dispose branch from 2e5546f to b0ef4f6 Compare February 1, 2022 15:29
@0xFA11 0xFA11 merged commit 8d6a860 into release/1.0.0 Feb 1, 2022
@0xFA11 0xFA11 deleted the fix-1.0.0/adapter-ondestroy-dispose branch February 1, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-lemay-unity @0xFA11 @NoelStephensUnity