fix: Correctly dispose of everything in adapter's OnDestroy #1640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-2305
Some of the native containers used by the adapter are not disposed of correctly when destroying the
UnityTransport
component. They're disposed of correctly when shutting down gracefully (through theShutdown
method), but not if the component is destroyed without shutting it down. To fix this, we now dispose of everything inOnDestroy
too.Changelog
com.unity.netcode.adapter.utp
Testing and Documentation