Skip to content

fix: rounding issue with tick calculation #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 25, 2022
Merged

fix: rounding issue with tick calculation #1614

merged 13 commits into from
Jan 25, 2022

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jan 24, 2022 •
edited
Loading

Fixing rounding issue with tick calculation.

MTT-2063

PR Checklist

  • Have you updated the changelog? Each package has a CHANGELOG.md file.

Changelog

com.unity.netcode.gameobjects

Fixed network tick value sometimes being duplicated or skipped.

Testing and Documentation

  • Includes unit test: NetworkTickAdvanceTest
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
fbab2a9 
Fixing rounding issue with tick calculation.
@NoelStephensUnity
test
e0c9686 
Added tick increment test to verify that the tick value no longer has the casted integer rounding error.
@NoelStephensUnity
Merge branch 'develop' into fix/ticksystem-duplicated-or-skipped-tick…
6dff0e3 
…-value
@0xFA11 0xFA11 mentioned this pull request Jan 24, 2022
Closed
3 tasks
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review January 24, 2022 19:27
@NoelStephensUnity
fix
021642d 
Had to do switch TestToFixedTime over to an approximated comparison due to the delta variances in the test values being used with the updated tick rounding fix.
@NoelStephensUnity
fix tests
74aa521 
Fixing some additional tests that appear to be taking into account the tick not being rounded.
@NoelStephensUnity
fix
94d2a3b 
Just testing a silly fix.
@NoelStephensUnity
Revert "fix tests"
cd8234b 
This reverts commit 74aa521.
@NoelStephensUnity
fix
7eb844d 
Slight modification and reverted some test changes back to original values.
@NoelStephensUnity
fix
f14b4a7 
increasing maximum rounding threshold to 0.999999999999
@NoelStephensUnity
refactor
0183149 
Just trying to condense the code a little and remove the Math.Round
LukeStampfli
LukeStampfli reviewed Jan 25, 2022
View reviewed changes
@NoelStephensUnity
refactor
646c899 
Removing the Math.Truncate stuff...
I think this is as condensed as it can possibly get.
@NoelStephensUnity
style
e67e428 
Adding comment as to what the precision check is for.
@NoelStephensUnity NoelStephensUnity merged commit e62fb4c into develop Jan 25, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/ticksystem-duplicated-or-skipped-tick-value branch January 25, 2022 15:31
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jan 25, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

@LukeStampfli LukeStampfli LukeStampfli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoelStephensUnity @0xFA11 @LukeStampfli