Skip to content

fix: rounding issue with tick calculation - release 1.0.0 backport #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jan 25, 2022

Fixing rounding issue with tick calculation.

MTT-2063

This is a backport of PR-1614

PR Checklist

  • Have you added a backport label (if needed)? For example, the type:backport-release-* label. After you backport the PR, the label changes to stat:backported-release-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.

Changelog

com.unity.netcode.gameobjects

Fixed network tick value sometimes being duplicated or skipped. (#1614)

Testing and Documentation

  • Includes unit test: NetworkTickAdvanceTest
  • No documentation changes or additions were necessary.

Applying the #1604 fix for this release/1.0.0 backport.
adding the unit test to verify the fix
updating the changelog to reflect the PR 1614.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review January 25, 2022 16:43
@ashwinimurt ashwinimurt merged commit 862c812 into release/1.0.0 Jan 25, 2022
@ashwinimurt ashwinimurt deleted the fix/ticksystem-duplicated-or-skipped-tick-value-release-1.0.0 branch January 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants