fix: Disallowed async keyword in RPCs #1587
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps a test would be nice? Feels like this check could easily be lost in a future refactor. |
|
I'm not sure how to write a test for compile failures... since any code that tests it would fail to compile. |
|
You could create dyanmically create and compile an assembly and read the compilation outputs. This can be done with the CodeDom compiler. |
|
Do you have an example you can point to? And, does that run the ILPP step, or do you know how to manually invoke it for the test? |
|
Continued on Slack for future reference. |
0xFA11
reviewed
Jan 15, 2022
| @@ -23,6 +23,7 @@ Additional documentation and release notes are available at [Multiplayer Documen | |||
| - Fixed error when serializing ConnectionApprovalMessage with scene management disabled when one or more objects is hidden via the CheckObjectVisibility delegate (#1509) | |||
| - Fixed The NetworkConfig's checksum hash includes the NetworkTick so that clients with a different tickrate than the server are identified and not allowed to connect. (#1513) | |||
| - Fixed OwnedObjects not being properly modified when using ChangeOwnership. (#1572) | |||
| - Disallowed async keyword in RPCs (1587) | |||
There was a problem hiding this comment.
nit
Suggested change
| - Disallowed async keyword in RPCs (1587) | |
| - Disallowed async keyword in RPCs (#1587) |
|
Reopened as #1681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-1588
fixes #570
Changelog
com.unity.netcode.gameobjects
Testing and Documentation