Skip to content

fix: Rename 'Send Queue Batch Size' field in adapter #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2022
Merged

fix: Rename 'Send Queue Batch Size' field in adapter #1584

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c82e4a
fix: Rename 'Send Queue Batch Size' field in adapter
simon-lemay-unity Jan 13, 2022
62f3973
Update com.unity.netcode.adapter.utp/CHANGELOG.md
simon-lemay-unity Jan 13, 2022
48c4614
Forgot to commit test fixes...
simon-lemay-unity Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Forgot to commit test fixes...
  • Loading branch information
@simon-lemay-unity
simon-lemay-unity committed Jan 14, 2022
commit 48c4614277fa17f5831b10ef535edff491c57fbf
2 changes: 1 addition & 1 deletion com.unity.netcode.adapter.utp/Tests/Runtime/Helpers/DriverClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class DriverClient : MonoBehaviour
private void Awake()
{

var maxCap = UnityTransport.InitialBatchQueueSize + 128;
var maxCap = UnityTransport.InitialMaxPayloadSize + 128;

var settings = new NetworkSettings();
settings.WithFragmentationStageParameters(payloadCapacity: maxCap);
Expand Down
4 changes: 2 additions & 2 deletions com.unity.netcode.adapter.utp/Tests/Runtime/TransportTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public IEnumerator SendMaximumPayloadSize([ValueSource("k_DeliveryParameters")]

yield return WaitForNetworkEvent(NetworkEvent.Connect, m_Client1Events);

var payload = new ArraySegment<byte>(new byte[UnityTransport.InitialBatchQueueSize]);
var payload = new ArraySegment<byte>(new byte[UnityTransport.InitialMaxPayloadSize]);
m_Client1.Send(m_Client1.ServerClientId, payload, delivery);

yield return WaitForNetworkEvent(NetworkEvent.Data, m_ServerEvents);
Expand Down Expand Up @@ -171,7 +171,7 @@ public IEnumerator FilledSendQueueMultipleSends([ValueSource("k_DeliveryParamete
yield return new WaitForSeconds(numSends * 0.02f);

// Extra event is the connect event.
Assert.AreEqual(m_ServerEvents.Count, numSends + 1);
Assert.AreEqual(numSends + 1, m_ServerEvents.Count);

for (int i = 1; i <= numSends; i++)
{
Expand Down