fix: Rename 'Send Queue Batch Size' field in adapter #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its actual meaning is to be the maximum payload size. The name is not entirely wrong, since this also happens to be the batch size for the send queue, but the field would still have a utility if we removed batching from the adapter, so 'Max Payload Size' is a more accurate name.
simon-lemay-unity
requested review from
0xFA11,
jeffreyrainy and
mattwalsh-unity
jeffreyrainy
approved these changes
Jan 13, 2022
0xFA11
reviewed
Jan 13, 2022
0xFA11
approved these changes
Jan 13, 2022
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
0xFA11
approved these changes
Jan 16, 2022
0xFA11
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its actual meaning is to be the maximum payload size. The name is not entirely wrong, since this also happens to be the batch size for the send queue, but the field would still have a utility if we removed batching from the adapter, so 'Max Payload Size' is a more accurate name.
We had not renamed it before because we didn't want to break compatibility, but I just learned of
FormerlySerializedAswhich allows renaming inspector fields while retaining the value assigned to their previous name. Using that to rename the field, we avoid a breaking change.This addresses MTT-2175.
Changelog
com.unity.netcode.adapter.utp
Testing and Documentation