fix: Add metrics pipeline stage to unreliable pipeline #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to include it in PR #1512...
0xFA11
approved these changes
Jan 6, 2022
|
Will be covered by #1583, closing this one without merging it. |
Rosme
pushed a commit
that referenced
this pull request
Jan 19, 2022
* First pass on moving data from pipeline stage to network metrics * Extract metrics from network pipeline stage * Updated based on comment, don't ignore exception anymore * Added third pipeline to network metrics * Followed comments: Avoid unneeded looping, better split of methods responsability * Integrated changes from PR #1569 into this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1512 added a new pipeline for unreliable traffic in the UTP adapter and I forgot to add
NetworkMetricsPipelineStageto this new pipeline in development builds. Oops.No JIRA item since this is just a minor fix of a previous change and there's no functional impact (the metrics pipeline stage doesn't do anything at the moment).
Changelog
com.unity.netcode.adapter.utp
N/A
Testing and Documentation