feat: Enable fragmentation for unreliable delivery (UTP) #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-lemay-unity
requested review from
ShadauxCat,
0xFA11,
andrews-unity and
jeffreyrainy
0xFA11
reviewed
Dec 8, 2021
| @@ -54,7 +62,7 @@ public IEnumerator Cleanup() | |||
|
|
|||
| // Check if can make a simple data exchange. | |||
| [UnityTest] | |||
| public IEnumerator PingPong() | |||
| public IEnumerator PingPong([ValueSource("k_DeliveryParameters")] NetworkDelivery delivery) | |||
There was a problem hiding this comment.
I didn't know about [ValueSource("k_DeliveryParameters")] syntax, nice!
0xFA11
approved these changes
Dec 8, 2021
andrews-unity
approved these changes
Dec 9, 2021
ShadauxCat
approved these changes
Dec 9, 2021
andrews-unity
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
simon-lemay-unity
added a commit
that referenced
this pull request
Jan 6, 2022
I forgot to include it in PR #1512...
This was referenced Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the UTP adapter to send
UnreliableandUnreliableSequencedtraffic through fragmented pipelines. This makes it so that all delivery methods will support fragmentation in the adapter. This also means the 'Send Queue Batch Size' setting now controls the maximum payload size for all delivery methods, not just the reliable ones.I'm debating backporting this change to 1.0.0, since this is mostly made in anticipation of the snapshot support. Thoughts?
Changelog
com.unity.netcode.adapter.utp
Testing and Documentation