fix: Console CI all green #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fect tests. The time for a network operation to complete is not dependent on framerate in any way.
…aitForMessageOfType
…uble value instead of the float value
0xFA11
approved these changes
Dec 17, 2021
0xFA11
reviewed
Feb 17, 2022
|
|
||
| public MessageReceiptCheck ReceiptCheck; | ||
| private class MultiInstanceHooks : INetworkHooks |
There was a problem hiding this comment.
this one fixes some bugs related to WaitForMessageOfType, so we should get at least changes in this file MultiInstanceHelpers.cs
There was a problem hiding this comment.
for other changes, they might be tricky to get back into develop — @NoelStephensUnity might help us here.
0xFA11
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
* logging pass Unity-Technologies#1 * Logging * Switched NetworkVarBufferCopyTest to use WaitForMessageOfType * Changed default "maxFrames" to "timeout" so that framerate doesn't affect tests. The time for a network operation to complete is not dependent on framerate in any way. * Switch NetworkObjectDestroy and NetworkObjectOwnership tests to use WaitForMessageOfType * RpcManyClientsTests updated to use WaitForMessageOfType * Attempting to change the assert in network time tests to using the double value instead of the float value * standards * Fixed mising meta file * ValueUpdateTests to use WaitForMessageOfType * standards Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-1553
Testing and Documentation