Skip to content

fix: increases maximum message size to int.MaxValue (#1384) #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrews-unity
Copy link
Contributor

Original PR: #1384

* fix: increases maximum message size to int.MaxValue

* Changelog entry

* - Fixed tools tests
- Fixed incorrect reporting of message size for Named and Unnamed message, not taking packing into account
- Fixed OnBeforeMessageRecieved() and OnAfterMessageReceived() being called twice for messages that are deferred when received

* Moved changelog entry to Unreleased

* Reverted unrelated change.

* Standards...
@andrews-unity andrews-unity enabled auto-merge (squash) November 24, 2021 12:06
@andrews-unity andrews-unity merged commit 766d690 into release/1.0.0 Nov 25, 2021
@andrews-unity andrews-unity deleted the backport/1.0.0-fix-increase_max_message_size branch November 25, 2021 18:14
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
…es#1384) (Unity-Technologies#1462)

* fix: increases maximum message size to int.MaxValue

* Changelog entry

* - Fixed tools tests
- Fixed incorrect reporting of message size for Named and Unnamed message, not taking packing into account
- Fixed OnBeforeMessageRecieved() and OnAfterMessageReceived() being called twice for messages that are deferred when received

* Moved changelog entry to Unreleased

* Reverted unrelated change.

* Standards...

Co-authored-by: Jaedyn Draper <284434+ShadauxCat@users.noreply.github.com>
Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants