fix: increases maximum message size to int.MaxValue #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed incorrect reporting of message size for Named and Unnamed message, not taking packing into account - Fixed OnBeforeMessageRecieved() and OnAfterMessageReceived() being called twice for messages that are deferred when received
| @@ -11,11 +11,12 @@ internal struct MessageHeader | |||
| /// unchanged - if new messages are added or messages are removed, MessageType assignments may be | |||
| /// calculated differently. | |||
| /// </summary> | |||
| public byte MessageType; | |||
| public uint MessageType; | |||
There was a problem hiding this comment.
Is this a required change for this PR?
There was a problem hiding this comment.
It's not required, no, but I thought it made sense. Making the other one larger meant it made sense to start packing the header. If the header's packed, then there's no reason to limit the number of messages to the byte range. It still ends up serialized as a byte due to packing.
| private object m_Owner; | ||
| private IMessageSender m_MessageSender; | ||
| private bool m_Disposed; | ||
|
|
||
| internal Type[] MessageTypes => m_ReverseTypeMap; | ||
| internal MessageHandler[] MessageHandlers => m_MessageHandlers; | ||
| internal int MessageHandlerCount => m_HighMessageType; |
There was a problem hiding this comment.
Same as above not clear why these changes are needed.
| }; | ||
| var type = m_ReverseTypeMap[header.MessageType]; |
There was a problem hiding this comment.
Is the moving of this code related to the original fix?
There was a problem hiding this comment.
Yes and no... one iteration of the fix did require this code to be moved... when I backtracked on that direction I realized the code still needed to be moved because as it is, it's dispatching profiling/metrics events twice for some messages. I can move it into a separate PR...
There was a problem hiding this comment.
Yes lets move that into a different PR
# Conflicts: # com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
andrews-unity
approved these changes
Nov 16, 2021
andrews-unity
pushed a commit
that referenced
this pull request
Nov 24, 2021
* fix: increases maximum message size to int.MaxValue * Changelog entry * - Fixed tools tests - Fixed incorrect reporting of message size for Named and Unnamed message, not taking packing into account - Fixed OnBeforeMessageRecieved() and OnAfterMessageReceived() being called twice for messages that are deferred when received * Moved changelog entry to Unreleased * Reverted unrelated change. * Standards...
andrews-unity
added a commit
that referenced
this pull request
Nov 25, 2021
* fix: increases maximum message size to int.MaxValue * Changelog entry * - Fixed tools tests - Fixed incorrect reporting of message size for Named and Unnamed message, not taking packing into account - Fixed OnBeforeMessageRecieved() and OnAfterMessageReceived() being called twice for messages that are deferred when received * Moved changelog entry to Unreleased * Reverted unrelated change. * Standards... Co-authored-by: Jaedyn Draper <284434+ShadauxCat@users.noreply.github.com> Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
andrews-unity
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…es#1384) * fix: increases maximum message size to int.MaxValue * Changelog entry * - Fixed tools tests - Fixed incorrect reporting of message size for Named and Unnamed message, not taking packing into account - Fixed OnBeforeMessageRecieved() and OnAfterMessageReceived() being called twice for messages that are deferred when received * Moved changelog entry to Unreleased * Reverted unrelated change. * Standards...
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…es#1384) (Unity-Technologies#1462) * fix: increases maximum message size to int.MaxValue * Changelog entry * - Fixed tools tests - Fixed incorrect reporting of message size for Named and Unnamed message, not taking packing into account - Fixed OnBeforeMessageRecieved() and OnAfterMessageReceived() being called twice for messages that are deferred when received * Moved changelog entry to Unreleased * Reverted unrelated change. * Standards... Co-authored-by: Jaedyn Draper <284434+ShadauxCat@users.noreply.github.com> Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-1646
Changelog
com.unity.netcode.gameobjects
Testing and Documentation