fix: (external) avoid NullReferenceException on ImportReferences call #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@andrews-unity we might consider backporting this to 1.0 — what do you think? |
andrews-unity
approved these changes
Nov 22, 2021
andrews-unity
added a commit
that referenced
this pull request
Nov 24, 2021
…#1434) * fix: NullReferenceException during ImportReferences in NetworkBehaviourILPP (#1378) In some cases, for example when assembly is System.Colletions.Immutable, null value is passed to .Add() method causing NullReferenceException during the build. Simply guarding against it solves the issue. Co-authored with @JadenH Co-authored-by: rafek <rafal.legiedz@gmail.com>
andrews-unity
added a commit
that referenced
this pull request
Nov 24, 2021
…#1434) (#1454) * fix: NullReferenceException during ImportReferences in NetworkBehaviourILPP (#1378) In some cases, for example when assembly is System.Colletions.Immutable, null value is passed to .Add() method causing NullReferenceException during the build. Simply guarding against it solves the issue. Co-authored with @JadenH Co-authored-by: rafek <rafal.legiedz@gmail.com>
andrews-unity
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…Unity-Technologies#1434) * fix: NullReferenceException during ImportReferences in NetworkBehaviourILPP (Unity-Technologies#1378) In some cases, for example when assembly is System.Colletions.Immutable, null value is passed to .Add() method causing NullReferenceException during the build. Simply guarding against it solves the issue. Co-authored with @JadenH * update changelog Co-authored-by: rafek <rafal.legiedz@gmail.com>
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…Unity-Technologies#1434) (Unity-Technologies#1454) * fix: NullReferenceException during ImportReferences in NetworkBehaviourILPP (Unity-Technologies#1378) In some cases, for example when assembly is System.Colletions.Immutable, null value is passed to .Add() method causing NullReferenceException during the build. Simply guarding against it solves the issue. Co-authored with @JadenH Co-authored-by: rafek <rafal.legiedz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1378 — NullReferenceException while building a project
Author: @rafek
Original PR: #1410
In some cases, for example when assembly is System.Colletions.Immutable, null value is passed to .Add() method causing NullReferenceException
during the build. Simply guarding against it solves the issue.
Co-authored with @JadenH
PR Checklist
type:backport-release-*label. After you backport the PR, the label changes tostat:backported-release-*.CHANGELOG.mdfile.Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR or a link to the documenation repo PR if this is a manual update.Changelog
com.unity.netcode.gameobjects
Testing and Documentation