Skip to content

fix: NullReferenceException during ImportReferences in #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rafek
Copy link

@rafek rafek commented Nov 10, 2021

NetworkBehaviourILPP (#1378)

In some cases, for example when assembly is System.Colletions.Immutable, null value is passed to .Add() method causing NullReferenceException
during the build. Simply guarding against it solves the issue.

Co-authored with @JadenH

PR Checklist

  • Have you added a backport label (if needed)? For example, the type:backport-release-* label. After you backport the PR, the label changes to stat:backported-release-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR or a link to the documenation repo PR if this is a manual update.

Changelog

com.unity.netcode.gameobjects

  • Added: The package whose Changelog should be added to should be in the header. Delete the changelog section entirely if it's not needed.
  • Fixed: If you update multiple packages, create a new section with a new header for the other package.
  • Removed/Deprecated/Changed: Each bullet should be prefixed with Added, Fixed, Removed, Deprecated, or Changed to indicate where the entry should go.

Testing and Documentation

  • No tests have been added.
  • Includes unit tests.
  • Includes integration tests.
  • No documentation changes or additions were necessary.
  • Includes documentation for previously-undocumented public API entry points.
  • Includes edits to existing public API documentation.

NetworkBehaviourILPP (Unity-Technologies#1378)

In some cases, for example when assembly is System.Colletions.Immutable, null value is passed to .Add() method causing NullReferenceException
during the build. Simply guarding against it solves the issue.

Co-authored with @JadenH
@unity-cla-assistant
Copy link

unity-cla-assistant commented Nov 10, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
we could pull this branch internally to run it against yamato ci checks and merge.

@rafek
Copy link
Author

rafek commented Nov 19, 2021

@MFatihMAR awesome! So we need to wait for @ShadauxCat to proceed?

@0xFA11 0xFA11 self-assigned this Nov 19, 2021
@0xFA11
Copy link
Contributor

0xFA11 commented Nov 19, 2021

I'll take care of this one :)

@0xFA11
Copy link
Contributor

0xFA11 commented Nov 19, 2021

will take this in very soon, here: #1434

@0xFA11 0xFA11 closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants