Skip to content

test: automated test for TestRails (rpc, ownership) #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

jeffreyrainy
Copy link
Contributor

'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership'

Automates manual test https://qatestrail.hq.unity3d.com/index.php?/tests/view/3022974&group_by=cases:section_id&group_order=asc&group_id=142359

MTT-678 (partial)

Testing and Documentation

  • Is integration test.
  • No documentation changes or additions were necessary.

…on and invocation being dropped/skipped for non-owners when RequireOwnership'
public class RpcOwnershipObject : NetworkBehaviour
{
public int RequireOwnershipCount = 0;
public int DoesntRequireOwnershipCount = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Mr. Nit Pick :P

Suggested change
public int DoesntRequireOwnershipCount = 0;
public int DoesNotRequireOwnershipCount = 0;

Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffreyrainy jeffreyrainy merged commit 9d6034e into develop Oct 26, 2021
@jeffreyrainy jeffreyrainy deleted the test/remove-manual-tests branch October 26, 2021 19:47
@jeffreyrainy jeffreyrainy restored the test/remove-manual-tests branch October 26, 2021 19:47
jeffreyrainy added a commit that referenced this pull request Oct 27, 2021
- C788896 Verify the user can define their own custom network serialized type
- C788897 Verify multiple custom types can be used in the same RPC parameter list
- C788899 Verify custom types and primitive types can be used in the same RPC parameter list
- C788900 Verify C# and Unity primitive types work without any new requirements/serialization
- C788901 Verify arrays of custom types are being serialized in the exact same order in both ends
- C788902 Verify empty arrays of custom types are being serialized
0xFA11 added a commit that referenced this pull request Oct 28, 2021
* test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership'

* test: forgotten .meta file in previous commit

* test: automated test for TestRails (rpc, ownership) (#1358)

- C788896 Verify the user can define their own custom network serialized type
- C788897 Verify multiple custom types can be used in the same RPC parameter list
- C788899 Verify custom types and primitive types can be used in the same RPC parameter list
- C788900 Verify C# and Unity primitive types work without any new requirements/serialization
- C788901 Verify arrays of custom types are being serialized in the exact same order in both ends
- C788902 Verify empty arrays of custom types are being serialized

Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
0xFA11 added a commit that referenced this pull request Oct 29, 2021
* test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership'

* test: forgotten .meta file in previous commit

* test: automated test for TestRails (rpc, ownership) (#1358)

- C788896 Verify the user can define their own custom network serialized type
- C788897 Verify multiple custom types can be used in the same RPC parameter list
- C788899 Verify custom types and primitive types can be used in the same RPC parameter list
- C788900 Verify C# and Unity primitive types work without any new requirements/serialization
- C788901 Verify arrays of custom types are being serialized in the exact same order in both ends
- C788902 Verify empty arrays of custom types are being serialized

* test: replace manual tests with automated tests (#1365)

- C788903	Verify null arrays of custom types are being serialized
- C788904	Verify RpcDelivery option exposed on both ServerRpc and ClientRpc attributes
- C788905	Verify RpcDelivery options are mapping to matching transport channels for replication
- C788906	Verify when RpcDelivery is not specified that Rpc still replicates
- C788912	Verify ServerRpc method with no parameters replicates from client to server
- C788913	Verify ClientRpc method with no parameters replicates from server to 1 client
- C788915	Verify ServerRpc method with 1 parameter replicates from client to server
- C788916	Verify ClientRpc method with 1 parameter replicates from server to 1 client
- C788918	Verify ServerRpc method with more than 1 parameters replicates from client to server
- C788919	Verify ClientRpc method with more than 1 parameters replicates from server to 1 client
- C788921	Verify C# and Unity primitive types are supported in Rpc method signatures
- C816309	Verify that sending Rpc messages are sent and received properly through the queue system
- C816312	Verifies the core functionality of the RcpQueueContainer

Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
…es#1358)

* test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership'

* test: forgotten .meta file in previous commit
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
)

* test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership'

* test: forgotten .meta file in previous commit

* test: automated test for TestRails (rpc, ownership) (Unity-Technologies#1358)

- C788896 Verify the user can define their own custom network serialized type
- C788897 Verify multiple custom types can be used in the same RPC parameter list
- C788899 Verify custom types and primitive types can be used in the same RPC parameter list
- C788900 Verify C# and Unity primitive types work without any new requirements/serialization
- C788901 Verify arrays of custom types are being serialized in the exact same order in both ends
- C788902 Verify empty arrays of custom types are being serialized

Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
…1373)

* test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership'

* test: forgotten .meta file in previous commit

* test: automated test for TestRails (rpc, ownership) (Unity-Technologies#1358)

- C788896 Verify the user can define their own custom network serialized type
- C788897 Verify multiple custom types can be used in the same RPC parameter list
- C788899 Verify custom types and primitive types can be used in the same RPC parameter list
- C788900 Verify C# and Unity primitive types work without any new requirements/serialization
- C788901 Verify arrays of custom types are being serialized in the exact same order in both ends
- C788902 Verify empty arrays of custom types are being serialized

* test: replace manual tests with automated tests (Unity-Technologies#1365)

- C788903	Verify null arrays of custom types are being serialized
- C788904	Verify RpcDelivery option exposed on both ServerRpc and ClientRpc attributes
- C788905	Verify RpcDelivery options are mapping to matching transport channels for replication
- C788906	Verify when RpcDelivery is not specified that Rpc still replicates
- C788912	Verify ServerRpc method with no parameters replicates from client to server
- C788913	Verify ClientRpc method with no parameters replicates from server to 1 client
- C788915	Verify ServerRpc method with 1 parameter replicates from client to server
- C788916	Verify ClientRpc method with 1 parameter replicates from server to 1 client
- C788918	Verify ServerRpc method with more than 1 parameters replicates from client to server
- C788919	Verify ClientRpc method with more than 1 parameters replicates from server to 1 client
- C788921	Verify C# and Unity primitive types are supported in Rpc method signatures
- C816309	Verify that sending Rpc messages are sent and received properly through the queue system
- C816312	Verifies the core functionality of the RcpQueueContainer

Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants