-
Notifications
You must be signed in to change notification settings - Fork 450
test: automated test for TestRails (rpc, ownership) #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on and invocation being dropped/skipped for non-owners when RequireOwnership'
0xFA11
reviewed
Oct 26, 2021
public class RpcOwnershipObject : NetworkBehaviour | ||
{ | ||
public int RequireOwnershipCount = 0; | ||
public int DoesntRequireOwnershipCount = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm Mr. Nit Pick :P
Suggested change
public int DoesntRequireOwnershipCount = 0; | |
public int DoesNotRequireOwnershipCount = 0; |
0xFA11
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jeffreyrainy
added a commit
that referenced
this pull request
Oct 27, 2021
- C788896 Verify the user can define their own custom network serialized type - C788897 Verify multiple custom types can be used in the same RPC parameter list - C788899 Verify custom types and primitive types can be used in the same RPC parameter list - C788900 Verify C# and Unity primitive types work without any new requirements/serialization - C788901 Verify arrays of custom types are being serialized in the exact same order in both ends - C788902 Verify empty arrays of custom types are being serialized
0xFA11
added a commit
that referenced
this pull request
Oct 28, 2021
* test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership' * test: forgotten .meta file in previous commit * test: automated test for TestRails (rpc, ownership) (#1358) - C788896 Verify the user can define their own custom network serialized type - C788897 Verify multiple custom types can be used in the same RPC parameter list - C788899 Verify custom types and primitive types can be used in the same RPC parameter list - C788900 Verify C# and Unity primitive types work without any new requirements/serialization - C788901 Verify arrays of custom types are being serialized in the exact same order in both ends - C788902 Verify empty arrays of custom types are being serialized Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
0xFA11
added a commit
that referenced
this pull request
Oct 29, 2021
* test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership' * test: forgotten .meta file in previous commit * test: automated test for TestRails (rpc, ownership) (#1358) - C788896 Verify the user can define their own custom network serialized type - C788897 Verify multiple custom types can be used in the same RPC parameter list - C788899 Verify custom types and primitive types can be used in the same RPC parameter list - C788900 Verify C# and Unity primitive types work without any new requirements/serialization - C788901 Verify arrays of custom types are being serialized in the exact same order in both ends - C788902 Verify empty arrays of custom types are being serialized * test: replace manual tests with automated tests (#1365) - C788903 Verify null arrays of custom types are being serialized - C788904 Verify RpcDelivery option exposed on both ServerRpc and ClientRpc attributes - C788905 Verify RpcDelivery options are mapping to matching transport channels for replication - C788906 Verify when RpcDelivery is not specified that Rpc still replicates - C788912 Verify ServerRpc method with no parameters replicates from client to server - C788913 Verify ClientRpc method with no parameters replicates from server to 1 client - C788915 Verify ServerRpc method with 1 parameter replicates from client to server - C788916 Verify ClientRpc method with 1 parameter replicates from server to 1 client - C788918 Verify ServerRpc method with more than 1 parameters replicates from client to server - C788919 Verify ClientRpc method with more than 1 parameters replicates from server to 1 client - C788921 Verify C# and Unity primitive types are supported in Rpc method signatures - C816309 Verify that sending Rpc messages are sent and received properly through the queue system - C816312 Verifies the core functionality of the RcpQueueContainer Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…es#1358) * test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership' * test: forgotten .meta file in previous commit
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
) * test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership' * test: forgotten .meta file in previous commit * test: automated test for TestRails (rpc, ownership) (Unity-Technologies#1358) - C788896 Verify the user can define their own custom network serialized type - C788897 Verify multiple custom types can be used in the same RPC parameter list - C788899 Verify custom types and primitive types can be used in the same RPC parameter list - C788900 Verify C# and Unity primitive types work without any new requirements/serialization - C788901 Verify arrays of custom types are being serialized in the exact same order in both ends - C788902 Verify empty arrays of custom types are being serialized Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…1373) * test: automated test for TestRails 'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership' * test: forgotten .meta file in previous commit * test: automated test for TestRails (rpc, ownership) (Unity-Technologies#1358) - C788896 Verify the user can define their own custom network serialized type - C788897 Verify multiple custom types can be used in the same RPC parameter list - C788899 Verify custom types and primitive types can be used in the same RPC parameter list - C788900 Verify C# and Unity primitive types work without any new requirements/serialization - C788901 Verify arrays of custom types are being serialized in the exact same order in both ends - C788902 Verify empty arrays of custom types are being serialized * test: replace manual tests with automated tests (Unity-Technologies#1365) - C788903 Verify null arrays of custom types are being serialized - C788904 Verify RpcDelivery option exposed on both ServerRpc and ClientRpc attributes - C788905 Verify RpcDelivery options are mapping to matching transport channels for replication - C788906 Verify when RpcDelivery is not specified that Rpc still replicates - C788912 Verify ServerRpc method with no parameters replicates from client to server - C788913 Verify ClientRpc method with no parameters replicates from server to 1 client - C788915 Verify ServerRpc method with 1 parameter replicates from client to server - C788916 Verify ClientRpc method with 1 parameter replicates from server to 1 client - C788918 Verify ServerRpc method with more than 1 parameters replicates from client to server - C788919 Verify ClientRpc method with more than 1 parameters replicates from server to 1 client - C788921 Verify C# and Unity primitive types are supported in Rpc method signatures - C816309 Verify that sending Rpc messages are sent and received properly through the queue system - C816312 Verifies the core functionality of the RcpQueueContainer Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Verify ServerRpc method replication and invocation being dropped/skipped for non-owners when RequireOwnership'
Automates manual test https://qatestrail.hq.unity3d.com/index.php?/tests/view/3022974&group_by=cases:section_id&group_order=asc&group_id=142359
MTT-678 (partial)
Testing and Documentation