fix: networkmanager prefab validation and no scene management manual test #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a typo in a comment in one of the newly added prefab registration checks added a check for a valid hash override but invalid target prefab
fixing comment and adding one of the potential invalid combinations (valid hash but invalid target prefab).
andrews-unity
approved these changes
Aug 23, 2021
…b.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/prefabValidationNoSceneManagement
0xFA11
reviewed
Aug 24, 2021
0xFA11
reviewed
Aug 24, 2021
0xFA11
reviewed
Aug 24, 2021
com.unity.netcode.gameobjects/Tests/Runtime/NetworkPrefabHandlerTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Aug 24, 2021
0xFA11
reviewed
Aug 24, 2021
0xFA11
reviewed
Aug 24, 2021
| @@ -465,7 +465,10 @@ private void Initialize(bool server) | |||
| // Build the NetworkPrefabOverrideLinks dictionary | |||
| for (int i = 0; i < NetworkConfig.NetworkPrefabs.Count; i++) | |||
| { | |||
| if (NetworkConfig.NetworkPrefabs[i] == null || NetworkConfig.NetworkPrefabs[i].Prefab == null) | |||
| var sourcePrefabGlobalObjectIdHash = (uint)0; | |||
There was a problem hiding this comment.
last but not least, I'd suggest to run ./standards.py --check and maybe ./standards.py --fix locally to check & fix spaces/namings locally — just in case :P
Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
…erTests.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
jeffreyrainy
approved these changes
Aug 24, 2021
0xFA11
approved these changes
Aug 24, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Aug 26, 2021
…hub.com:Unity-Technologies/com.unity.multiplayer.mlapi into sam/feature/interpolation-for-network-transform * 'sam/feature/interpolation-for-network-transform' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: test: NetworkTransformStateTests no longer uses ReplNetworkState (#1084) fix: networkmanager prefab validation and no scene management manual test (#1073) feat: snapshot. MTT-1088 Snapshot acknowledgment gaps (#1083) feat: Add a test to validate registration of metric types (#1072) chore!: Remove unsupported UNET Relay behavior (MTT-1000) (#1081) fix: 2+ inheritance from network behaviour causes compilation exception (#1078) (#1079) test: add networkscenemanager additive scene loading tests (#1076)
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…test (Unity-Technologies#1073) * fix This fixes issues with NetworkManager prefab override validation. If you never assigned a Prefab but just wanted to override it would fail. It never properly checked all potential cases, which this fixes. * test This validates the fixes as well as tests that disabling original/legacy scene management works. * fix Fixing issue with the wrong brackets around the wrong pair of initial checks for NetworkPrefab validation. Updated the NetworkPrefabHandlerTests to account for all potential scenarios that should be handled without causing initialization to fail. * refactor and style fixed a typo in a comment in one of the newly added prefab registration checks added a check for a valid hash override but invalid target prefab * test and style fixing comment and adding one of the potential invalid combinations (valid hash but invalid target prefab). * fix Fixing issue with the prefab not pointing to the right network prefab which made the client side not register the proper network prefab to override since disabling scene management requires that in-scene placed NetworkObjects be spawned by the server. * Update com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com> * Update com.unity.netcode.gameobjects/Tests/Runtime/NetworkPrefabHandlerTests.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com> * Update com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com> * Update com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com> * Update com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com> Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues with NetworkManager prefab override validation as well as includes some modifications to the EnableDisableSceneNetworkObject sample where EnableSceneManagement is disabled in order to validate this works as well.
Additional automated tests will be created in the updated NetworkSceneManager Tests contained within PR-1030.
Since this included some NetworkManager changes, I wanted to keep this PR separate.