Skip to content

Feature/initial relay utp remove relay sdk calls #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thoward-unity
Copy link
Contributor

Extracted Relay SDK calls out of UTP adapter for MLAPI; it now accepts a variable passed in via a setter method. Also updated the sample test project included to illustrate these changes.

Made some changes that address feedback comments; mainly restructured the manner that code external to UTPTransport passes in the requisite relay server data so that external code doesn't need to know about the internal data structures that UTPTransport uses.

Removed minor changes that were erroneously left in when taking other approaches.

…ow accepts a variable passed in via a setter method. Also updated the sample test project included to illustrate these changes.
…tructured the manner that code external to UTPTransport passes in the requisite relay server data so that external code doesn't need to know about the internal data structures that UTPTransport uses.
Copy link
Contributor

@simon-lemay-unity simon-lemay-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, but no major blockers for me.

@thoward-unity thoward-unity merged commit b8be4a4 into feature/initial-relay-utp Aug 10, 2021
@thoward-unity thoward-unity deleted the feature/initial-relay-utp-remove-relay-sdk-calls branch August 10, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants