Merge branch 'develop' into sam/feature/interpolation-for-network-transform

* develop: (32 commits)
  refactor: calling networkShow(NetworkObject) code in networkshow(List<NetworkObject>) (#1028)
  feat: snapshot. MTT-685 MTT-822 (#1021)
  test: adding a multi-instance test checking NetworkShow and NetworkHide on lists of objects (#1036)
  fix: corrected NetworkVariable WriteField/WriteDelta/ReadField/ReadDelta dropping the last byte if unaligned. (#1008)
  chore: run standards check over solution files (#1027)
  chore: replace MLAPI with Netcode in Markdown files (#1025)
  fix!: added plainly-callable Add() method to NetworkSet [MTT-1005] (#1022)
  fix: fixing incorrect merge done as part of commit 85842ee (#1023)
  chore: cleanup/upgrade serialized scenes (#1020)
  chore: replace MLAPI with Netcode in C# source files (#1019)
  test: add network collections, struct and class tests MTT-936 (#1000)
  test: add buildtests to test build pipeline on target platforms (#1018)
  chore: rename MLAPI types to Netcode (#1017)
  chore!: rename asmdefs, change top-level namespaces (#1015)
  Replacing community NetworkManagerHUD with a simpler implementation (#993)
  test: network prefab pools and INetworkPrefabInstanceHandler (#1004)
  fix: do not expose Runtime internals to TestProject.ManualTests asmdef (#1014)
  refactor: snapshot. merge preparation. Removing old acks, removing unused varia… (#1013)
  chore!: per-asmdef namespaces instead of per-folder (#1009)
  feat: snapshot. ground work, preparing depedencies. No impact on code behaviour (#1012)
  ...

# Conflicts:
#	com.unity.multiplayer.mlapi/Prototyping/NetworkTransform.cs
#	com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs

Author: SamuelBellomo

.editorconfig

@@ -14,6 +14,7 @@ indent_size = 4
 # formatting rules
 dotnet_diagnostic.IDE0001.severity = error # Simplify name
 dotnet_diagnostic.IDE0002.severity = error # Simplify member access
+dotnet_diagnostic.IDE0005.severity = error # Remove unnecessary import
 dotnet_style_qualification_for_field = false:error
 dotnet_style_qualification_for_property = false:error
 dotnet_style_qualification_for_method = false:error
@@ -26,7 +27,7 @@ csharp_prefer_braces = true:error
 csharp_using_directive_placement = outside_namespace:error
 
 # naming rules
-# namespace MLAPI { ... }
+# namespace Unity.Netcode { ... }
 # public class NetworkObject { ... }
 # public void Spawn(...) { ... }
 dotnet_naming_symbols.usertypes_naming_symbols.applicable_kinds = namespace, class, struct, enum, property, method, field, event, delegate, local_function
@@ -101,4 +102,4 @@ dotnet_naming_style.memberfield_naming_style.required_prefix = m_
 dotnet_naming_style.memberfield_naming_style.capitalization = pascal_case
 dotnet_naming_rule.memberfield_naming_rule.symbols = memberfield_naming_symbols
 dotnet_naming_rule.memberfield_naming_rule.style = memberfield_naming_style
-dotnet_naming_rule.memberfield_naming_rule.severity = error
+dotnet_naming_rule.memberfield_naming_rule.severity = error

.github/ISSUE_TEMPLATE/bug_report.md

@@ -29,8 +29,8 @@ If applicable, add screenshots to help explain your problem.
 **Environment (please complete the following information):**
  - OS: [e.g. Windows 10]
  - Unity Version: [e.g. 2019.1]
- - MLAPI Version: [e.g. v6.0.1]
- - MLAPI Commit: [e.g. https://github.com/Unity-Technologies/com.unity.multiplayer.mlapi/commit/c102935df1d7e0928283b48948fe96e5d96dd961]
+ - Netcode Version: [e.g. v6.0.1]
+ - Netcode Commit: [e.g. https://github.com/Unity-Technologies/com.unity.multiplayer.mlapi/commit/c102935df1d7e0928283b48948fe96e5d96dd961]
 
 **Additional context**
 Add any other context about the problem here. Logs, code snippets would be useful here but please also consider attaching a minimal Unity project that reproduces the issue.

.github/ISSUE_TEMPLATE/feedback.md

@@ -1,14 +1,14 @@
 ---
 name: Feedback
-about: Provide feedback to the MLAPI team
+about: Provide feedback to the Netcode for GameObjects team
 title: ''
 labels: stat:awaiting triage, type:feedback
 assignees: ''
 
 ---
 
 **Feedback**
-Enter your feedback to the MLAPI team here. Please keep in mind that our teams focus is on multiplayer development. For other non-networking related feedback towards Unity please use the Forums.
+Enter your feedback to the Netcode for GameObjects team here. Please keep in mind that our teams focus is on multiplayer development. For other non-networking related feedback towards Unity please use the Forums.
 
 **Suggested Changes**
 If you think we could do something better, please let us know here what you would like us to change. Concrete and constructive suggestions are welcome and will help us to prioritize and act on feedback.

.github/ISSUE_TEMPLATE/support.md

@@ -9,4 +9,4 @@ assignees: ''
 
 Post your questions or problems here.
 
-For general questions, networking advice or discussions about MLAPI, you can also reach us on our [Discord Community](https://discord.gg/FM8SE9E) or create a post in the [Unity Multiplayer Forum](https://forum.unity.com/forums/multiplayer.26/).
+For general questions, networking advice or discussions about the Netcode for GameObjects, you can also reach us on our [Discord Community](https://discord.gg/FM8SE9E) or create a post in the [Unity Multiplayer Forum](https://forum.unity.com/forums/multiplayer.26/).

CONTRIBUTING.md

@@ -14,11 +14,11 @@ Here are our guidlines for contributing:
 
 ## <a name="coc"></a> Code of Conduct
 
-Please help us keep MLAPI open and inclusive. Read and follow our [Code of Conduct](CODE_OF_CONDUCT.md).
+Please help us keep Unity Netcode for GameObjects open and inclusive. Read and follow our [Code of Conduct](CODE_OF_CONDUCT.md).
 
 ## <a name="ways"></a> Ways to Contribute
 
-There are many ways in which you can contribute to the MLAPI.
+There are many ways in which you can contribute to Netcode for GameObjects.
 
 ### <a name="issue"></a> Issues and Bugs
 
@@ -46,7 +46,7 @@ When you open a pull request, you will be asked to enter into Unity's License Ag
 
 ## <a name="submit-pr"></a> Pull Request Submission Guidelines
 
-We use the [Gitflow Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow) for the development of MLAPI. This means development happens on the **develop branch** and Pull Requests should be submited to it.
+We use the [Gitflow Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow) for the development of the Netcode for GameObjects. This means development happens on the **develop branch** and Pull Requests should be submited to it.
 
 ### Commit Message Guidelines
 We have very precise rules over how our git commit messages can be formatted.  This leads to **more
@@ -108,4 +108,4 @@ Always write a clear log message for your commits. One-line messages are fine fo
 
     $ git commit -m "A brief summary of the commit
     > 
-    > A paragraph describing what changed and its impact."
+    > A paragraph describing what changed and its impact."

com.unity.multiplayer.mlapi/Documentation~/Manual.md

@@ -1,29 +1,30 @@
-# About MLAPI
+# About Netcode for GameObjects
 
-Unity MLAPI is a high level networking library built for the Unity game engine to abstract networking. This allows developers to focus on the game rather than low level protocols and networking frameworks. 
+Unity Netcode for GameObjects is a high-level networking library built to abstract networking. This allows developers to focus on the game rather than low level protocols and networking frameworks. 
 
-##  Unity MLAPI 
+## Guides
 
-See this guide to install Unity MLAPI, set up your project, and get started with your first networked game.
+See guides below to install Unity Netcode for GameObjects, set up your project, and get started with your first networked game:
 
-* [MLAPI Documentation](https://docs-multiplayer.unity3d.com/docs/getting-started/about-mlapi)
-* [Install MLAPI](https://docs-multiplayer.unity3d.com/docs/migration/install)
-* [First Steps with Unity MLAPI](https://docs-multiplayer.unity3d.com/docs/tutorials/helloworldintro)
-* [MLAPI API Reference](https://docs-multiplayer.unity3d.com/docs/mlapi-api/introduction)
+* [Documentation](https://docs-multiplayer.unity3d.com/docs/getting-started/about-mlapi)
+* [Installation](https://docs-multiplayer.unity3d.com/docs/migration/install)
+* [First Steps](https://docs-multiplayer.unity3d.com/docs/tutorials/helloworldintro)
+* [API Reference](https://docs-multiplayer.unity3d.com/docs/mlapi-api/introduction)
 
 # Technical details
 
 ## Requirements
 
-This version of MLAPI is compatible with the following versions of the Unity Editor:
+This version of Netcode for GameObjects is compatible with the following Unity versions and platforms:
 
 * 2020.3 and later
-* Windows, Mac, Linux platforms are supported by MLAPI
+* Windows, Mac, Linux platforms
 
 ## Document revision history
 
 |Date|Reason|
 |---|---|
 |March 10, 2021|Document created. Matches package version 0.1.0|
-|June 1, 2021| Updated and added links for additional content. Matches patch version 0.1.0 and hotfixes.|
-|June 3, 2021| Update document to acknowledge Unity min version change. Matches package version 0.2.0|
+|June 1, 2021|Update and add links for additional content. Matches patch version 0.1.0 and hotfixes.|
+|June 3, 2021|Update document to acknowledge Unity min version change. Matches package version 0.2.0|
+|August 5, 2021|Update product/package name|

com.unity.multiplayer.mlapi/Editor/CodeGen/CodeGenHelpers.cs

@@ -3,21 +3,18 @@
 using System.IO;
 using System.Linq;
 using System.Text;
-using MLAPI.Hashing;
-using MLAPI.Messaging;
-using MLAPI.Serialization;
 using Mono.Cecil;
 using Mono.Cecil.Cil;
 using Mono.Cecil.Rocks;
 using Unity.CompilationPipeline.Common.Diagnostics;
 using Unity.CompilationPipeline.Common.ILPostProcessing;
 using UnityEngine;
 
-namespace MLAPI.Editor.CodeGen
+namespace Unity.Netcode.Editor.CodeGen
 {
     internal static class CodeGenHelpers
     {
-        public const string RuntimeAssemblyName = "Unity.Multiplayer.MLAPI.Runtime";
+        public const string RuntimeAssemblyName = "Unity.Netcode.Runtime";
 
         public static readonly string NetworkBehaviour_FullName = typeof(NetworkBehaviour).FullName;
         public static readonly string ServerRpcAttribute_FullName = typeof(ServerRpcAttribute).FullName;
@@ -281,10 +278,10 @@ public static AssemblyDefinition AssemblyDefinitionFor(ICompiledAssembly compile
 
             var assemblyDefinition = AssemblyDefinition.ReadAssembly(new MemoryStream(compiledAssembly.InMemoryAssembly.PeData), readerParameters);
 
-            //apparently, it will happen that when we ask to resolve a type that lives inside MLAPI.Runtime, and we
-            //are also postprocessing MLAPI.Runtime, type resolving will fail, because we do not actually try to resolve
+            //apparently, it will happen that when we ask to resolve a type that lives inside Unity.Netcode.Runtime, and we
+            //are also postprocessing Unity.Netcode.Runtime, type resolving will fail, because we do not actually try to resolve
             //inside the assembly we are processing. Let's make sure we do that, so that we can use postprocessor features inside
-            //MLAPI.Runtime itself as well.
+            //Unity.Netcode.Runtime itself as well.
             assemblyResolver.AddAssemblyDefinitionBeingOperatedOn(assemblyDefinition);
 
             return assemblyDefinition;

com.unity.multiplayer.mlapi/Editor/CodeGen/NetworkBehaviourILPP.cs

@@ -3,9 +3,6 @@
 using System.Linq;
 using System.Collections.Generic;
 using System.Reflection;
-using MLAPI.Logging;
-using MLAPI.Messaging;
-using MLAPI.Serialization;
 using Mono.Cecil;
 using Mono.Cecil.Cil;
 using Mono.Cecil.Rocks;
@@ -16,7 +13,7 @@
 using ParameterAttributes = Mono.Cecil.ParameterAttributes;
 using ILPPInterface = Unity.CompilationPipeline.Common.ILPostProcessing.ILPostProcessor;
 
-namespace MLAPI.Editor.CodeGen
+namespace Unity.Netcode.Editor.CodeGen
 {
     internal sealed class NetworkBehaviourILPP : ILPPInterface
     {

com.unity.multiplayer.mlapi/Editor/CodeGen/PostProcessorAssemblyResolver.cs

@@ -6,7 +6,7 @@
 using Mono.Cecil;
 using Unity.CompilationPipeline.Common.ILPostProcessing;
 
-namespace MLAPI.Editor.CodeGen
+namespace Unity.Netcode.Editor.CodeGen
 {
     internal class PostProcessorAssemblyResolver : IAssemblyResolver
     {

com.unity.multiplayer.mlapi/Editor/CodeGen/PostProcessorReflectionImporter.cs

@@ -2,7 +2,7 @@
 using System.Reflection;
 using Mono.Cecil;
 
-namespace MLAPI.Editor.CodeGen
+namespace Unity.Netcode.Editor.CodeGen
 {
     internal class PostProcessorReflectionImporter : DefaultReflectionImporter
     {

com.unity.multiplayer.mlapi/Editor/CodeGen/PostProcessorReflectionImporterProvider.cs

@@ -1,6 +1,6 @@
 using Mono.Cecil;
 
-namespace MLAPI.Editor.CodeGen
+namespace Unity.Netcode.Editor.CodeGen
 {
     internal class PostProcessorReflectionImporterProvider : IReflectionImporterProvider
     {

com.unity.multiplayer.mlapi/Editor/CodeGen/RuntimeAccessModifiersILPP.cs

@@ -6,7 +6,7 @@
 using Unity.CompilationPipeline.Common.ILPostProcessing;
 using ILPPInterface = Unity.CompilationPipeline.Common.ILPostProcessing.ILPostProcessor;
 
-namespace MLAPI.Editor.CodeGen
+namespace Unity.Netcode.Editor.CodeGen
 {
     internal sealed class RuntimeAccessModifiersILPP : ILPPInterface
     {
@@ -29,7 +29,7 @@ public override ILPostProcessResult Process(ICompiledAssembly compiledAssembly)
             var assemblyDefinition = CodeGenHelpers.AssemblyDefinitionFor(compiledAssembly);
             if (assemblyDefinition == null)
             {
-                m_Diagnostics.AddError($"Cannot read MLAPI Runtime assembly definition: {compiledAssembly.Name}");
+                m_Diagnostics.AddError($"Cannot read Netcode Runtime assembly definition: {compiledAssembly.Name}");
                 return null;
             }
 
@@ -52,15 +52,15 @@ public override ILPostProcessResult Process(ICompiledAssembly compiledAssembly)
                         case nameof(NetworkBehaviour):
                             ProcessNetworkBehaviour(typeDefinition);
                             break;
-                        case nameof(Messaging.__RpcParams):
+                        case nameof(__RpcParams):
                             typeDefinition.IsPublic = true;
                             break;
                     }
                 }
             }
             else
             {
-                m_Diagnostics.AddError($"Cannot get main module from MLAPI Runtime assembly definition: {compiledAssembly.Name}");
+                m_Diagnostics.AddError($"Cannot get main module from Netcode Runtime assembly definition: {compiledAssembly.Name}");
             }
 
             // write

com.unity.multiplayer.mlapi/Editor/CodeGen/Unity.Multiplayer.MLAPI.Editor.CodeGen.asmdef

@@ -0,0 +1,19 @@
+{
+    "name": "Unity.Netcode.Editor.CodeGen",
+    "rootNamespace": "Unity.Netcode.Editor.CodeGen",
+    "references": [
+        "Unity.Netcode.Runtime"
+    ],
+    "includePlatforms": [
+        "Editor"
+    ],
+    "allowUnsafeCode": true,
+    "overrideReferences": true,
+    "precompiledReferences": [
+        "Mono.Cecil.dll",
+        "Mono.Cecil.Mdb.dll",
+        "Mono.Cecil.Pdb.dll",
+        "Mono.Cecil.Rocks.dll"
+    ],
+    "autoReferenced": false
+}

com.unity.multiplayer.mlapi/Editor/CodeGen/com.unity.netcode.editor.codegen.asmdef

@@ -1,9 +1,8 @@
 using System;
 
-namespace MLAPI.Editor
+namespace Unity.Netcode.Editor
 {
     public class DontShowInTransportDropdownAttribute : Attribute
     {
-
     }
 }