-
Notifications
You must be signed in to change notification settings - Fork 839
Automatically enable Alpha-To-Coverage when alpha clipping is on #6599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea in general and I agree it's also good to align on what URP does.
I'm for deleting reference of it in the editor, but it can still be interesting to note it in the doc that we use this method / algorithm by default in the MSAA / Alpha Clipping docs just for the sake of it because it was implemented recently-ish (1 year ago)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Feature has been tested and tests are still passing ✔️
* Reenable "Automatically enable Alpha-To-Coverage when alpha clipping is on (#6599)" * Workaround shadow bug
Purpose of this PR
Removed the alpha to coverage option on material and shadergraphs, it will now be always enabled in forward msaa when alpha clipping is on.
URP will do it like that with #6312 and it's actually a good idea since the performance cost is minimal and it removes a shader variant. Also it's much simpler to setup because not a lot of users know about this option
There was also a frame setting to enable/disable alpha to coverage per camera. I also removed it, but maybe there can be an interest in keeping it.
I removed every mention of alpha to coverage in the docs, and search all occurence of alphatocoverage in code to make sure i removed everything.
NOTE: i'll have to mention the change in what's new if we want to merge
Testing status
There are two tests 9402 that test alpha to coverage with regular shaders and shadergraphs, they don't change with this PR
Tested that in deferred, and forward without msaa there is no issue.
Yamato looks green
Comments to reviewers
Notes for the reviewers you have assigned.