Skip to content

[HDRP] Automatic alpha to coverage #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

adrien-de-tocqueville
Copy link
Contributor

@adrien-de-tocqueville adrien-de-tocqueville commented Jan 6, 2022

Purpose of this PR

PR to reenable automatic alpha to coverage that was reverted due to a broken DXR test
This PR addtionally includes a change to workaround the issue, which has been reported here https://fogbugz.unity3d.com/f/cases/1392756/
(The bug is in shadow mapping, where removing ALPHATOMASK keyword would batch non batchable renderers, worked around by enabling gpu instancing on one material to prevent it from being batched with others)


Testing status

see original PR + tested failing DXR test + launched yamato
HDRP_DXR fails for infratructure reasons apparently but problematic test 902 is green locally

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@adrien-de-tocqueville adrien-de-tocqueville changed the title Hd/automatic alpha to coverage [HDRP] Automatic alpha to coverage Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit 3940534 into master Jan 13, 2022
@sebastienlagarde sebastienlagarde deleted the hd/automatic-alpha-to-coverage branch January 13, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants