Skip to content

Revert "Automatically enable Alpha-To-Coverage when alpha clipping is on (#6599)" #6650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

Revert "Automatically enable Alpha-To-Coverage when alpha clipping is on (#6599)" #6650

merged 1 commit into from
Dec 17, 2021

Conversation

JulienIgnace-Unity
Copy link
Contributor

Purpose of this PR

Revert "Automatically enable Alpha-To-Coverage when alpha clipping is on (#6599)"

@JulienIgnace-Unity
Revert "Automatically enable Alpha-To-Coverage when alpha clipping is…
93c6346 
… on (#6599)"

This reverts commit e7a2db2.

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
#	com.unity.render-pipelines.high-definition/Documentation~/Upgrading-from-2022.1-to-2022.2.md
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@JulienIgnace-Unity JulienIgnace-Unity merged commit 1eceaae into master Dec 17, 2021
@JulienIgnace-Unity JulienIgnace-Unity deleted the hd/revert-6599 branch December 17, 2021 16:05
@LaserYGD
Copy link

LaserYGD commented Dec 17, 2021 •
edited
Loading

Hi,
was there an issue with the original PR adding this, and is it coming back?

@JulienIgnace-Unity
Copy link
Contributor Author

Yes it broke some behaviors with double sided shadow flag on mesh renderers. We'll come back to it once the relevant people are back from vacation in early january.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde Awaiting requested review from sebastienlagarde

Assignees
No one assigned
Labels
HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulienIgnace-Unity @LaserYGD