Skip to content

[HDRP] Fix new pathtracer stacklit test failing for XR + Update 3DS max test with new reference image #6098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2021
Merged

[HDRP] Fix new pathtracer stacklit test failing for XR + Update 3DS max test with new reference image #6098

merged 2 commits into from
Oct 21, 2021

Conversation

remi-chapelain
Copy link
Contributor

@remi-chapelain remi-chapelain commented Oct 21, 2021 •
edited
Loading

Purpose of this PR

PR is needed because this commit that fixes the import type of normal texture (from default to normal) for 3dsMax Physical shader graph broke the 3dsMax test. Updating the screenshots was needed.

Also, this commit (same PR) added a test to prevent regression from stacklit shader master node (and 3DSMaxPhysical graph too) but XR Compatible was left checked which cause XR test to fail. This PR unchecks this too.

Testing status

Re ran concerned test locally.

  • 5007_PathTracing_Materials_StackLit => still ✔️
  • 1550_3dsMax => Now ✔️

Comments to reviewers

Trivial fix, no need to go deeper.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@remi-chapelain remi-chapelain marked this pull request as ready for review October 21, 2021 13:31
@sebastienlagarde sebastienlagarde merged commit 9804081 into master Oct 21, 2021
@sebastienlagarde sebastienlagarde deleted the hd/fix-3ds-max-broken-test-and-stacklit-test branch October 21, 2021 13:32
sebastienlagarde pushed a commit that referenced this pull request Oct 21, 2021
@remi-chapelain @sebastienlagarde
[HDRP] Fix new pathtracer stacklit test failing for XR + Update 3DS m…
9785480 
…ax test with new reference image (#6098)

* uncheck XR compatibilty for new pathtracer test

* update 1550_3dsMax reference images
odbb added a commit that referenced this pull request Oct 21, 2021
@odbb
Merge branch 'master' into adaptive-performance/add-decals-scaler
36bbf62 
* master:
  [HDRP][URP][SpeedTree8] Set shadergraph as default SpeedTree 8 shader for Universal. Clean up HDRP importers/upgraders. (#5851)
  Remove emissive contribution when current depth < min depth. (#6099)
  [HDRP] Fix new pathtracer stacklit test failing for XR + Update 3DS max test with new reference image (#6098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Assignees
No one assigned
Labels
backported-2021.2 HDRP testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remi-chapelain @sebastienlagarde