Skip to content

[HDRP][Path Tracing] Remove emissive contribution when current depth < min depth #6099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

[HDRP][Path Tracing] Remove emissive contribution when current depth < min depth #6099

merged 1 commit into from
Oct 21, 2021

Conversation

eturquin
Copy link
Contributor

Tiny change, to be in line with the recent, similar change on contribution from the sky on camera rays.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit 53a657b into master Oct 21, 2021
@sebastienlagarde sebastienlagarde deleted the hd/pt_emissive_min_depth branch October 21, 2021 13:33
sebastienlagarde pushed a commit that referenced this pull request Oct 21, 2021
@eturquin @sebastienlagarde
Remove emissive contribution when current depth < min depth. (#6099)
edf45dc
odbb added a commit that referenced this pull request Oct 21, 2021
@odbb
Merge branch 'master' into adaptive-performance/add-decals-scaler
36bbf62 
* master:
  [HDRP][URP][SpeedTree8] Set shadergraph as default SpeedTree 8 shader for Universal. Clean up HDRP importers/upgraders. (#5851)
  Remove emissive contribution when current depth < min depth. (#6099)
  [HDRP] Fix new pathtracer stacklit test failing for XR + Update 3DS max test with new reference image (#6098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Assignees
No one assigned
Labels
backported-2021.2 dxr HDRP SRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eturquin @sebastienlagarde