Skip to content

SRP bump to 13.1.1 #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2021
Merged

SRP bump to 13.1.1 #6041

merged 3 commits into from
Oct 18, 2021

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Oct 18, 2021

Purpose of this PR

https://unity.slack.com/archives/C20E70CAC/p1633945527342700?thread_ts=1633090025.276200&cid=C20E70CAC
Did not touch the templates (must be bumped in a separate PR once SRP 13.1.1 is available in unity)

Testing status

Safety net + Package suite

Comments to reviewers

Retro updated all changelogs

@theopnv theopnv requested review from a team as code owners October 18, 2021 08:06
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@theopnv theopnv merged commit 18167b9 into master Oct 18, 2021
@theopnv theopnv deleted the srp/bump-13.1.1 branch October 18, 2021 09:20
odbb added a commit that referenced this pull request Oct 18, 2021
@odbb
Merge branch 'master' into adaptive-performance/add-decals-scaler
1964f32 
* master: (148 commits)
  [HDRP] Add custom pass buffer scaling functions (#5809)
  Fix HDRP template input not working when using the new Input System and no Keyboard/Mouse (#6045)
  [SRP] Bump package version to 13.2.0 (#6049)
  ** Improving FTPL perf on ps4 by .3 ms on average ** (#5866)
  Remove min version from package.json (#6044)
  Fix subdiv view (#6033)
  Small qol (#6036)
  APV: update some tooltips and add a clamp on dilation validity threshold (#6005)
  SRP bump to 13.1.1 (#6041)
  (SRP] Bump min version to a12 to fix Yamato
  Vfx/fix/1289612 filter texture by dimension (#5715)
  [HDRP] Fix 9601/9602 reference screenshots after cache server weirdness
  [CI] [trunk] Updated editor to 5a5aca0fb632e01b9b362f6deb73bcf599d612ca
  [CI] [trunk] Updated editor to 7b5b9bb6eed88e40de00efa2a629dd8f0b2bfee2
  [CI] [trunk] Updated editor to a397ac6302d3ce68bd3eeea7721610a649addfa3
  [CI] [trunk] Updated editor to dd9d77b7ded66b5edad4dacf123ffbb6c8d8c4bf
  [CI] [trunk] Updated editor to 6c7822fe613adfea64bb232c817a2fdee34fc273
  [CI] [trunk] Updated editor to aae7fd02ff5afebc831948d25c52dcf704a8a3f3
  [CI] [trunk] Updated editor to 9c278756e419ae931cabac6c5dd60f24e05c6de3
  [CI] [trunk] Updated editor to d3dc7fc8d330da1155ec00683876a559b2a63281
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phi-lira phi-lira phi-lira approved these changes

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Assignees
No one assigned
Labels
HDRP sdet Shader Graph SRP universal vfx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theopnv @phi-lira @sebastienlagarde @theo-at-unity