Skip to content

Update reflection probe tooltips. #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update reflection probe tooltips. #6037

wants to merge 2 commits into from

Conversation

eh-unity
Copy link
Contributor

Purpose of this PR

Update tooltips according to the quality audit.

Testing status

N/A, just tooltip text changed.

Comments to reviewers

Notes for the reviewers you have assigned.

@eh-unity eh-unity requested a review from pbbastian October 15, 2021 16:16
@eh-unity eh-unity marked this pull request as ready for review October 15, 2021 16:16
@eh-unity eh-unity requested review from a team as code owners October 15, 2021 16:16
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@eh-unity eh-unity removed the request for review from pbbastian October 20, 2021 11:57
phi-lira added a commit that referenced this pull request Oct 20, 2021
@phi-lira
Update reflection probe tooltips. #6037
46b45e3 
commit 4e33d42
Author: Erik Hakala <erik.hakala@unity3d.com>
Date:   Fri Oct 15 18:27:32 2021 +0300

    Adjust bias tooltips according to the audit.

commit 7c54164
Author: Erik Hakala <erik.hakala@unity3d.com>
Date:   Wed Oct 13 13:42:58 2021 +0300

    Fix camera enum display name.
@phi-lira phi-lira mentioned this pull request Oct 20, 2021
Merged
phi-lira added a commit that referenced this pull request Oct 22, 2021
@phi-lira
Update reflection probe tooltips. #6037
140af17 
commit 4e33d42
Author: Erik Hakala <erik.hakala@unity3d.com>
Date:   Fri Oct 15 18:27:32 2021 +0300

    Adjust bias tooltips according to the audit.

commit 7c54164
Author: Erik Hakala <erik.hakala@unity3d.com>
Date:   Wed Oct 13 13:42:58 2021 +0300

    Fix camera enum display name.
@phi-lira
Copy link
Contributor

Merged onto staging branch. Staging branch landed onto master on #6085

@phi-lira phi-lira closed this Oct 22, 2021
@phi-lira phi-lira deleted the universal/quality-audit-eh branch November 17, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbbastian pbbastian pbbastian approved these changes

@phi-lira phi-lira phi-lira approved these changes

@alex-vazquez alex-vazquez alex-vazquez approved these changes

Assignees
No one assigned
Labels
universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eh-unity @phi-lira @pbbastian @alex-vazquez