Skip to content

Universal Staging #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Universal Staging #5998

wants to merge 11 commits into from

Conversation

phi-lira
Copy link
Contributor

@phi-lira phi-lira commented Oct 12, 2021 •
edited
Loading

Staging Branch:

maloyer-unity and others added 8 commits October 12, 2021 16:06
@maloyer-unity @phi-lira
[XR][URP] Fix issue with vignette location in XR (#5471)
76ca87c 
* [XR][URP] Fix issue with vignette location in XR

Vignette center needs to respect the real view center since in XR, with asymmetric FOV, the center of the render taget is not always the center of the view. We deduce the real center via the projection matrix data and use that to offset the vignette's center.

* Updated changelog

* Extracted comon XRView code into ComputeEyeCenterUV & Allow more than 2 XR views

* Fix vignette movement direction for XR when whe change the vignette "center" parameter

* Returning to 2 views only for XR vignette.

This will keep the shader as simple as possible, if we need to support more views in the future, we can restore this code

* Use "Vector4.zero" instead of "new Vector4(0.0f, 0.0f, 0.0f, 0.0f)"

* Only set v3 if we are using single pass

That variable is only needed if single-pass instancing/multiview is active, so we can simplify the code to only do the asymetric FOV correction when we are in multi-pass mode.

* More improvements

- Renamed _Vignette_Params3 to _Vignette_ParamsXR
- Moved all single-pass XR values in _Vignette_ParamsXR
- Extracted code to correct eye center to XRPass class

* Adding a comment to describe what ApplyXRViewCenterOffset does

* Quick fix a comment that is not right anymore after moving the code
@pema99 @phi-lira
Remove deprecated UNITY_USE_NATIVE_HDR keyword from shader code. (#5569)
b7d61ab
@tomzig16 @phi-lira
Fix error when using gizmos with camera stack in editor (#5913)
09e6f3a 
* Fix game window gizmos when camera stack is used

* Remove Assert check for the last camera in stack

* Add lastCameraInStack check
@ellioman @Verasl
@kaychang-unity @phi-lira
[2022.1] Fix for specular materials in URP (Case 1326941) (#4798)
dcc687a 
* Fix for specular color plus a first draft of a test scene for it

* Minor color updates

* Test updated

* Adding Directional Light

* Adding the new test scene to build settings

* Reference Images

* Redoing the specular bugfix after various changes happened on Master

* Adding a Deferred Test Scene

* Fixing Specular on Deferred and adding a test scene for it as well

* Same fix but in ShaderGraph shaders

* Filtering out the 011 deferred scene for Android Vulkan (Issue: 1340634) and updating three reference images

* D3D11 updated reference image.

* Set a valid stencil format when creating depthStencil render-target.

* D3D12 reference image

* D3D11 reference image

* DX11 Deferred Reference image

* Removing a scene from the testcase filters as the issue has been resolved

* Changelog

Co-authored-by: Andrem <andrem@unity3d.com>
Co-authored-by: Kay Chang <kaychang@unity3d.com>
Co-authored-by: Felipe Lira <felipedrl@gmail.com>
@ellioman @phi-lira
[2022.1] Universal: Fixing 146 MSAA test scene. (#3570)
6da7afc 
* Fixing 146 MSAA test.

* Revert "Fixing 146 MSAA test."

This reverts commit a0c849e.

* Fixing MSAA test scene

* Minor cleanup of RP Assets.

* Reverting a change in GraphicsSettings and QualitySettings

* Materials

* Reverting a change in QualitySettings

* Increasing the test threshold from 0 to 0.0025

* Lowering the threshold to 0.001

* Updating Reference Images for DX11 and DX12
@manuele-bonanno
emitting UI geometry for offscreen cameras too (case 1344969 fix) (#5894
b4f79f0 
)
@manuele-bonanno
[URP] Re-enable ios pbr tests (#5983)
194b882 
* reenabled tests 024, 025, 026

* Added new iPhone reference images for tests 024, 025, 026
@phi-lira
Squashed commit of the following:
b0ee854 
commit 669789b
Merge: 5ef3bcc be573f7
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri Aug 27 08:10:46 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 5ef3bcc
Merge: b72a4ed 73ef535
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Wed Aug 25 14:49:56 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit b72a4ed
Merge: a211ff4 00abfa2
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon Jun 14 14:41:58 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit a211ff4
Merge: de69352 170b7ed
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Tue Jun 8 12:55:01 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit de69352
Merge: 0b9bc99 4e13f51
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri Jun 4 11:32:35 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 0b9bc99
Merge: 7809cba 4dc46c9
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon May 31 14:36:51 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 7809cba
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon May 31 14:32:15 2021 +0200

    Removing a Debug.Log line.

commit e3eda78
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri May 28 16:08:47 2021 +0200

    Forgot to add the changes to the build settings

commit 5bd01ea
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri May 28 15:15:26 2021 +0200

    Test scenes for the Volume Update Feature
@phi-lira phi-lira requested review from a team as code owners October 12, 2021 17:44
@github-actions
Copy link

github-actions bot commented Oct 12, 2021 •
edited
Loading

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@ernestasKupciunas ernestasKupciunas self-requested a review October 14, 2021 09:34
ernestasKupciunas
ernestasKupciunas approved these changes Oct 14, 2021
View reviewed changes
Copy link

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No issues were found related to this branch. RCA either wasn't needed or it was done by the developers.
Testing doc: https://docs.google.com/document/d/11U2qui9BxvqnITT0PXhZTRGM4kpcU-Vyvm23LhvqA_M/edit?usp=sharing

@phi-lira phi-lira requested a review from a team as a code owner October 15, 2021 15:57
@phi-lira phi-lira removed the request for review from a team October 15, 2021 16:07
@phi-lira phi-lira closed this Oct 18, 2021
@phi-lira phi-lira deleted the universal/staging branch October 18, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestasKupciunas ernestasKupciunas ernestasKupciunas approved these changes

Assignees
No one assigned
Labels
Shader Graph testing universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@phi-lira @ernestasKupciunas @maloyer-unity @pema99 @tomzig16 @ellioman @manuele-bonanno