Skip to content

[2022.1] Adding test scenes for the Volume Update Feature #4708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[2022.1] Adding test scenes for the Volume Update Feature #4708

wants to merge 10 commits into from

Conversation

ellioman
Copy link
Contributor

@ellioman ellioman commented May 28, 2021 •
edited
Loading

Purpose of this PR

The PR for controlling Volume Updates (#4242) added a test scene but was not enabled for our CI as we wanted to do that in a separate PR. This PR splits that test scene into three separate tests:

  • Test EveryFrame
  • Test UsePipeline
  • Test ViaScripting

The test works by waiting a single frame and then moving the camera a little bit so it is out of the bounds for the local volume before capturing the screen. The EveryFrame and UsePipeline test results should look the same and only be affected by the global volume. The ViaScripting should keep the state done initially which is the settings done in the local volume.

Testing status

Tested locally in the editor.

Yamato

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Fenable-160-test/.yamato%252Fall-urp_postpro.yml%2523Nightly_URP_PostPro_trunk/7074845/job/pipeline

@ellioman ellioman marked this pull request as ready for review June 3, 2021 14:41
@ellioman ellioman requested review from a team June 3, 2021 14:43
@ellioman ellioman removed the testing label Jun 3, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@ellioman ellioman changed the title [2021.2] Adding test scenes for the Volume Update Feature [2022.1] Adding test scenes for the Volume Update Feature Oct 12, 2021
@phi-lira phi-lira changed the base branch from master to universal/staging October 12, 2021 10:04
@phi-lira phi-lira deleted the branch master October 12, 2021 14:07
@phi-lira phi-lira closed this Oct 12, 2021
@phi-lira
Copy link
Contributor

Reopening, this was closed due to a mistake in the universal/staging PR being deleted.

@phi-lira phi-lira reopened this Oct 12, 2021
@phi-lira
Copy link
Contributor

Fixed conflicts and merged manually to staging branch.

@phi-lira phi-lira closed this Oct 12, 2021
@phi-lira phi-lira mentioned this pull request Oct 12, 2021
Closed
@phi-lira phi-lira reopened this Oct 18, 2021
Base automatically changed from universal/staging to master October 19, 2021 11:29
@phi-lira phi-lira requested a review from a team as a code owner October 19, 2021 11:29
@ellioman
Merge branch 'master' into universal/enable-160-test
8fad502 
# Conflicts:
#	TestProjects/UniversalGraphicsTest_PostPro/ProjectSettings/EditorBuildSettings.asset
phi-lira added a commit that referenced this pull request Oct 20, 2021
@phi-lira
Adding test scenes for the Volume Update Feature #4708
d071134 
commit 8fad502
Merge: 669789b 5b53dd5
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Tue Oct 19 13:35:00 2021 +0200

    Merge branch 'master' into universal/enable-160-test

    # Conflicts:
    #	TestProjects/UniversalGraphicsTest_PostPro/ProjectSettings/EditorBuildSettings.asset

commit 669789b
Merge: 5ef3bcc be573f7
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri Aug 27 08:10:46 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 5ef3bcc
Merge: b72a4ed 73ef535
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Wed Aug 25 14:49:56 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit b72a4ed
Merge: a211ff4 00abfa2
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon Jun 14 14:41:58 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit a211ff4
Merge: de69352 170b7ed
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Tue Jun 8 12:55:01 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit de69352
Merge: 0b9bc99 4e13f51
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri Jun 4 11:32:35 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 0b9bc99
Merge: 7809cba 4dc46c9
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon May 31 14:36:51 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 7809cba
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon May 31 14:32:15 2021 +0200

    Removing a Debug.Log line.

commit e3eda78
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri May 28 16:08:47 2021 +0200

    Forgot to add the changes to the build settings

commit 5bd01ea
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri May 28 15:15:26 2021 +0200

    Test scenes for the Volume Update Feature
@phi-lira phi-lira mentioned this pull request Oct 20, 2021
Merged
phi-lira added a commit that referenced this pull request Oct 22, 2021
@phi-lira
Adding test scenes for the Volume Update Feature #4708
c1052ad 
commit 8fad502
Merge: 669789b 5b53dd5
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Tue Oct 19 13:35:00 2021 +0200

    Merge branch 'master' into universal/enable-160-test

    # Conflicts:
    #	TestProjects/UniversalGraphicsTest_PostPro/ProjectSettings/EditorBuildSettings.asset

commit 669789b
Merge: 5ef3bcc be573f7
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri Aug 27 08:10:46 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 5ef3bcc
Merge: b72a4ed 73ef535
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Wed Aug 25 14:49:56 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit b72a4ed
Merge: a211ff4 00abfa2
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon Jun 14 14:41:58 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit a211ff4
Merge: de69352 170b7ed
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Tue Jun 8 12:55:01 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit de69352
Merge: 0b9bc99 4e13f51
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri Jun 4 11:32:35 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 0b9bc99
Merge: 7809cba 4dc46c9
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon May 31 14:36:51 2021 +0200

    Merge branch 'master' into universal/enable-160-test

commit 7809cba
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Mon May 31 14:32:15 2021 +0200

    Removing a Debug.Log line.

commit e3eda78
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri May 28 16:08:47 2021 +0200

    Forgot to add the changes to the build settings

commit 5bd01ea
Author: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Date:   Fri May 28 15:15:26 2021 +0200

    Test scenes for the Volume Update Feature
@phi-lira
Copy link
Contributor

Merged on staging branch #6085

@phi-lira phi-lira closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phi-lira phi-lira phi-lira approved these changes

@erikabar erikabar erikabar approved these changes

Assignees
No one assigned
Labels
universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellioman @phi-lira @erikabar