Skip to content

[URP] Re-enable ios pbr tests #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2021
Merged

[URP] Re-enable ios pbr tests #5983

merged 3 commits into from
Oct 12, 2021

Conversation

manuele-bonanno
Copy link
Contributor

@manuele-bonanno manuele-bonanno commented Oct 12, 2021 •
edited
Loading

Purpose of this PR

Reenabling iPhone foundation tests 024,025,026

Testing status

Yamato URP foundation green run

Comments to reviewers

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@manuele-bonanno manuele-bonanno marked this pull request as ready for review October 12, 2021 10:15
@phi-lira phi-lira changed the base branch from master to universal/staging October 12, 2021 14:19
@phi-lira phi-lira merged commit 194b882 into universal/staging Oct 12, 2021
@phi-lira phi-lira deleted the urp/reenable_ios_pbr_tests branch October 12, 2021 14:19
@phi-lira phi-lira mentioned this pull request Oct 12, 2021
Closed
@phi-lira phi-lira restored the urp/reenable_ios_pbr_tests branch October 18, 2021 15:14
@phi-lira phi-lira deleted the urp/reenable_ios_pbr_tests branch October 18, 2021 15:22
phi-lira added a commit that referenced this pull request Oct 18, 2021
@phi-lira
[URP] Re-enable ios pbr tests #5983
5f75d42 
commit 666523c
Author: Manuele Bonanno <manuele.bonanno@unity3d.com>
Date:   Tue Oct 12 11:21:34 2021 +0200

    Added new iPhone reference images for tests 024, 025, 026

commit 2cbfc51
Merge: e39f7eb dfba8e3
Author: Manuele Bonanno <manuele.bonanno@unity3d.com>
Date:   Tue Oct 12 10:17:32 2021 +0200

    Merge branch 'master' into urp/reenable_ios_pbr_tests

commit e39f7eb
Author: Manuele Bonanno <manuele.bonanno@unity3d.com>
Date:   Tue Oct 12 10:16:26 2021 +0200

    reenabled tests 024, 025, 026
@phi-lira phi-lira mentioned this pull request Oct 18, 2021
Merged
odbb added a commit that referenced this pull request Oct 19, 2021
@odbb
Merge branch 'master' into adaptive-performance/add-decals-scaler
6e903e4 
* master:
  Enable iris normal for Eye shader (#5880)
  Update to HDRP Asset analytics (#6060)
  [HDPR] Update reference screenshots for Linux Vulkan
  Update 206_Motion_Vectors.png (#6046)
  Updated code owner for URP (#6052)
  [URP] Re-enable ios pbr tests #5983
  Fix error when using gizmos with camera stack in editor #5913
  emitting UI geometry for offscreen cameras too (case 1344969 fix) #5894
  Remove deprecated UNITY_USE_NATIVE_HDR keyword from shader code. #5569
  [XR][URP] Fix issue with vignette location in XR #5471 #5471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellioman ellioman ellioman approved these changes

Assignees
No one assigned
Labels
testing universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuele-bonanno @ellioman @phi-lira