[9.x.x] Reverting changes that disabled pow() warnings in SpeedTree shaders #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellioman
changed the title
This was referenced Apr 30, 2020
phi-lira
approved these changes
Apr 30, 2020
|
The shader graph tests are broken in master and are unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This is a revert of #146 where I disabled pow() warnings that occur in SpeedTree shaders.
This caused issues when making builds for PS4 & PS5.
A PR has been made to trunk that fixes the warning in SpeedTreeWind.cginc.
Yamato
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Frevert-speedtree-warning
Testing status
Manual Tests: What did you do?