Skip to content

[8.x.x Backport] Reverting changes that disabled pow() warnings in SpeedTree shaders #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

ellioman
Copy link
Contributor

@ellioman ellioman commented Apr 30, 2020

Purpose of this PR

Backport of #334

This is a revert of #261 where I disabled pow() warnings that occur in SpeedTree shaders.
This caused issues when making builds for PS4 & PS5.

A PR has been made to trunk that fixes the warning in SpeedTreeWind.cginc.

Yamato

https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/8.x.x%252Funiversal%252Frevert-speedtree-warning

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

@ellioman ellioman requested a review from a team as a code owner April 30, 2020 11:53
@ellioman ellioman changed the base branch from master to 8.x.x/release April 30, 2020 11:57
@ellioman ellioman requested review from a team and removed request for a team April 30, 2020 11:57
@ellioman ellioman merged commit 6ade7f7 into 8.x.x/release Apr 30, 2020
@ellioman ellioman deleted the 8.x.x/universal/revert-speedtree-warning branch April 30, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants