Skip to content

[Yamato] Exclude docs in expression triggers #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 25, 2021
Merged

Conversation

sophiaaar
Copy link
Contributor

@sophiaaar sophiaaar commented Jan 25, 2021

Purpose of this PR

  • Excluded docs changes from per-project expression triggers
  • Updated the trigger on the package jobs (I don't think this worked before)

Testing status

  • Changed some md files and pushed to confirm that no jobs started
  • Updated the package job trigger and pushed, confirmed package jobs started

Comments to reviewers

Un-drafting early so I can test the trigger

@sophiaaar sophiaaar marked this pull request as ready for review January 25, 2021 13:34
@sophiaaar sophiaaar requested a review from a team as a code owner January 25, 2021 13:34
Copy link
Contributor

@theopnv theopnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the Documentation exclusion for the core package too? https://github.com/Unity-Technologies/Graphics/blob/yamato/docs-trigger/.yamato/_abv.yml#L26

@sophiaaar sophiaaar merged commit d10d3cc into master Jan 25, 2021
@sophiaaar sophiaaar deleted the yamato/docs-trigger branch January 25, 2021 15:53
sophiaaar added a commit that referenced this pull request Jan 26, 2021
sophiaaar added a commit that referenced this pull request Jan 26, 2021
sophiaaar added a commit that referenced this pull request Jan 26, 2021
sophiaaar added a commit that referenced this pull request Jan 26, 2021
* backport #2843

* backport #2883

* backport #3002

* shadergraph osx editor images

* move shadergraph linux vulkan images

* pdate vfx images

* update shadergraph ios images

* remove linux vulkan standalone from urp ci

* backport #3130

* backport #3175

* backport f61eaa4

* edit pr job and nightly

* part 2

* change timeout for standalone cache

* update hdrp images

* fix expression trigger branch

* backport #3254

* remove trigger from custom revision jobs
pastasfuture pushed a commit that referenced this pull request Mar 15, 2021
* backport #2843

* backport #2883

* backport #3002

* shadergraph osx editor images

* move shadergraph linux vulkan images

* pdate vfx images

* update shadergraph ios images

* remove linux vulkan standalone from urp ci

* backport #3130

* backport #3175

* backport f61eaa4

* edit pr job and nightly

* part 2

* change timeout for standalone cache

* update hdrp images

* fix expression trigger branch

* backport #3254

* remove trigger from custom revision jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants