Hdrp/fix 1299233 ies resize #3243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Not checking NdotL since it's not really valid for area lights (We have multiple valid light directions, not one) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
#3035) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed ShaderGraph decal draw order * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed access to invalid Contexts references after exiting playmode. * Fixed comparison gizmo after playmode. * Fixes from PR feedback
… conserving specular color option for the specular input parametrization (similar to case 1257050) (#3060)
* adding a shadow mask test * Update reference images
…ity) to improve visual quality. (#3020) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…er (case 1303504). (#3027) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…). (#3029) * - Changed the warning message for ray traced area shadows (case 1303410). * Adds approximation information about ray-traced area shadows Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ale rtao > 1.25 with a 25cm falloff interval. (#3023) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed Render Graph immediate mode. (#3033) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix issue with shadow mask and area lights (#3019) * Not checking NdotL since it's not really valid for area lights (We have multiple valid light directions, not one) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with capture callback (now includes post processing results) (#3035) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix decal draw order for ShaderGraph decal materials (#3018) * Fixed ShaderGraph decal draw order * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed various Look Dev issues after exiting Playmode (#2956) * Fixed access to invalid Contexts references after exiting playmode. * Fixed comparison gizmo after playmode. * Fixes from PR feedback * StackLit: Fix SG surface option property block to only display energy conserving specular color option for the specular input parametrization (similar to case 1257050) (#3060) * Fixed missing BeginCameraRendering call for custom render mode of a Camera (#3063) * Implement custom drawer for layer mask parameters (#3066) * Adding mixed light baking shadowmask test (#3052) * adding a shadow mask test * Update reference images * Fixing hull constant shader's tesselation cull algorithm. Before it was comparing edges being out of the frustum. This is wrong because the camera could be inside a triangle, in which case the edges could be out of at least 1 frustum plane. Correct fix is to check all three vertices if they are out of at least 1 plane. Result packed tightly into the functions w return component. * Renamed to a new function so we keep backwards compatibility. Restored the shadow shader pass path, accidentally changed it to bool4 and use near plane. * Fixing type back to bool, instead of bool4 * Merging changelog information from rebase. * Making sure scene declaration pass is a bool4 * Adding new test for tesselation culling, with a weird camera angle which fails previous setup. * Fixing formatting of code, rearranging order of test in editor build settings. * Adding reference images for test. * Missing meta file for new tests * Fix bad merge issue * fix bad merge issue * fix bad merge issue Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com>
…HDRP/fix_1299233_IES_Resize # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md # com.unity.render-pipelines.high-definition/CHANGELOG.md
…HDRP/fix_1299233_IES_Resize # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md
sebastienlagarde
approved these changes
Mar 1, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Mar 1, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Mar 1, 2021
* Hdrp/fix 1299233 ies resize #3243 * Fixed an issue in the planar reflection probe convolution. #3668 * Making the FrameSettingsAttribute field more robust. Using it in other places to avoid caching (#3700) the Obsoletes. Adding robustness in map query. * [HDRP] Merge Hd/bugfix #3687 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 3, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Mar 3, 2021
* Fixed a regression introduced when changing the clamping algorithm for RTR and RTGI (case 1307479). (#3206) * rename occurrences of sample when used as a variable name (#3216) rename occurrences of sample when used as a shader variable name as this may be a reserved word in certain situatons * [HDRP] Update eye sample scene #3227 * Change the tooltip for color shadows and semi-transparent shadows (case 1307704). (#3237) * [Hdrp] Add 3DS max shader material test (#3239) * Arnold + Physical material * auto desk interactive * Reference image from yamato * linux vulkan test ref image * Hdrp/fix 1299233 ies resize #3243 * [HDRP] Fix metal warning + fix reference screenshots + disable unstable metal test #3251 * [HDRP] update some docs based on latest changelog (#3253) * Update some docs * Proof read upgrading to 2020.2 * Proof read whats new doc * Fixed typo Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: peterjohnlong <73894199+peterjohnlong@users.noreply.github.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recreate #3094
Fix:
https://fogbugz.unity3d.com/f/cases/1299233/ (cf. Video)
Repro bug:
To see Atlas Display Cookie Atlas (make sure Clear Cookie Atlas is NOT checked)
Notice when clear cookie atlas we don't have the issue.
This PR fix this issue.
Make sure that don't break the others features of the Atlas (for example Animated RenderTexture).