Changed the clamping approach for RTR and RTGI (in both perf and quality) to improve visual quality. #3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity) to improve visual quality.
anisunity
requested review from
sebastienlagarde,
pierre-unity and
remi-chapelain
remi-chapelain
approved these changes
Jan 8, 2021
sebastienlagarde
approved these changes
Jan 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do to the very small budget of samples and execution time that we have, we need to clamp the values before denoising. The previous strategy for denoising de-saturated the values a bit too much. This PR changes the strategy for reflections and GI improving singificantly the visual quality for low clamp values.
Testing status
Tested with a bunch of lighting setups, made sure that the changes made on the tests made sense and updated the screenshots