[Hdrp] Add 3DS max shader material test #3239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-chapelain
changed the title
remi-chapelain
requested review from
sebastienlagarde,
Thomasch-unity3d and
a team
Thomasch-unity3d
approved these changes
Jan 22, 2021
sebastienlagarde
approved these changes
Jan 22, 2021
|
Linux Vulkan test image have been updated again. |
iM0ve
approved these changes
Jan 25, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Feb 14, 2021
* Arnold + Physical material * auto desk interactive * Reference image from yamato * linux vulkan test ref image
sebastienlagarde
added a commit
that referenced
this pull request
Feb 14, 2021
* [Hdrp] Add 3DS max shader material test (#3239) * Arnold + Physical material * auto desk interactive * Reference image from yamato * linux vulkan test ref image * Update HDRP-Asset.md (#3302) * Merge Hd/bugfix #3313 * Added master stack documentation for HDRP #3388 * Fix compilation issue in MaterialUIBlockLists * Reset ambient probe upon switching to very different skies bis #3423 * Some leftover caused by master merge (#3456) * Custom Pass error message fix #3424 * Colored Shadows update (#3486) * Colored Shadows update Included new information in the Color Shadow property description to tell the user that the Material's Refraction Model has to be set to Thin, Box or Sphere for it to work. * Fixed typo Removed the "the" :D Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 3, 2021
* Arnold + Physical material * auto desk interactive * Reference image from yamato * linux vulkan test ref image
sebastienlagarde
added a commit
that referenced
this pull request
Mar 3, 2021
* Fixed a regression introduced when changing the clamping algorithm for RTR and RTGI (case 1307479). (#3206) * rename occurrences of sample when used as a variable name (#3216) rename occurrences of sample when used as a shader variable name as this may be a reserved word in certain situatons * [HDRP] Update eye sample scene #3227 * Change the tooltip for color shadows and semi-transparent shadows (case 1307704). (#3237) * [Hdrp] Add 3DS max shader material test (#3239) * Arnold + Physical material * auto desk interactive * Reference image from yamato * linux vulkan test ref image * Hdrp/fix 1299233 ies resize #3243 * [HDRP] Fix metal warning + fix reference screenshots + disable unstable metal test #3251 * [HDRP] update some docs based on latest changelog (#3253) * Update some docs * Proof read upgrading to 2020.2 * Proof read whats new doc * Fixed typo Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: peterjohnlong <73894199+peterjohnlong@users.noreply.github.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Add coverage for the 3DS max materials :
Testing status
Test pass locally ✔️
Yamato (in progress) : https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Fadd-3DS-shader-material-test/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk/5010452/job
Comments to reviewers
I believe some shaders in some feature are not working (for example, bump map and/or bump map strength in Physical Material). Maps and slider are still not null, so if it get fixed/implemented, test will begin to fail.
Screenshots are up to date from yamato.