Skip to content

[8.x.x] [VFX] Fix Compilation with old input system (1297444) #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

PaulDemeulenaere
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere commented Dec 5, 2020

Purpose of this PR

Fix this issue (1297444), this is a regression with unexpected backport #2669

It generates a compilation error when com.unity.inputsystem is installed.

Testing status

The error is pretty straightforward, if #2042 isn't backported, we should not include this change, ENABLE_LEGACY_INPUT_MANAGER can be equals to 0 if new input system is installed and Active Input Handling is set to New (Both or Old are defining ENABLE_LEGACY_INPUT_MANAGER).

I think these changes should be double check by QA, the simple repro step is :

  • Create a new empty 3D project using 2020.1
  • Add com.unity.visualeffectgraph package 8.3.1
  • Add com.unity.inputsystem package : 1.0.0 or greater

TODO

Fix changelog ? Is it correct to anticipate for 8.3.2 ?

@github-actions github-actions bot added the vfx label Dec 5, 2020
@Unity-Technologies Unity-Technologies deleted a comment from github-actions bot Dec 5, 2020
@PaulDemeulenaere PaulDemeulenaere changed the title [VFX] Fix Compilation with old input system [8.x.x] [VFX] Fix Compilation with old input system Dec 5, 2020
@VladNeykov VladNeykov requested review from JMargevics and removed request for VladNeykov December 11, 2020 15:46
@JMargevics JMargevics requested a review from VitaVFX December 14, 2020 13:28
Copy link

@VitaVFX VitaVFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  1. VFXInputKeyBinder and VFXInputButtonBinder #define directives
  2. Empty project by following reproduction steps provided in this PR

Environment: macOS 11.0, Windows 10

Didn't find any issues, everything works fine on my side

@JMargevics JMargevics removed their request for review December 17, 2020 09:15
@sebastienlagarde
Copy link
Contributor

Closing as we do'nt produce 8.x package anymore

@PaulDemeulenaere PaulDemeulenaere changed the title [8.x.x] [VFX] Fix Compilation with old input system [8.x.x] [VFX] Fix Compilation with old input system (1297444) Feb 7, 2021
@PaulDemeulenaere
Copy link
Contributor Author

FYI : we received some vote count about this bug & user report (using 2020.1.16) but since we aren't planning any new release of 8.3.x, I guess we should update the resolution status.

@sebastienlagarde sebastienlagarde deleted the 8.x.x/vfx/fix/1297444-fix-compilation branch September 1, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants