[8.x.x] [VFX] Fix Compilation with old input system (1297444) #2857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix this issue (1297444), this is a regression with unexpected backport #2669
It generates a compilation error when
com.unity.inputsystem
is installed.Testing status
The error is pretty straightforward, if #2042 isn't backported, we should not include this change, ENABLE_LEGACY_INPUT_MANAGER can be equals to 0 if new input system is installed and
Active Input Handling
is set toNew
(Both
orOld
are defining ENABLE_LEGACY_INPUT_MANAGER).I think these changes should be double check by QA, the simple repro step is :
TODO
Fix changelog ? Is it correct to anticipate for 8.3.2 ?