Skip to content

[8.x.x] [VFX] Fix Compilation with old input system (1297444) #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[8.x.x] [VFX] Fix Compilation with old input system (1297444) #2857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0acaab2
Revert unexpected change in IntputButtonBinders
PaulDemeulenaere Dec 5, 2020
9a66499
Update changelog.md
PaulDemeulenaere Dec 5, 2020
134c73d
Same issue with VFXInputKeyBinder
PaulDemeulenaere Dec 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions com.unity.visualeffectgraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this package will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [8.3.2] - XXXX-XX-XX

### Fixed
- Fix unexpected compilation error without the new input system package [Case 1297444](https://issuetracker.unity3d.com/product/unity/issues/guid/1297444/)

## [8.3.1] - 2020-07-23

### Added
Expand Down
2 changes: 0 additions & 2 deletions ...isualeffectgraph/Runtime/Utilities/PropertyBinding/Implementation/VFXInputButtonBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ class VFXInputButtonBinder : VFXBinderBase
public float SmoothSpeed = 2.0f;
public bool UseButtonSmooth = true;

#if ENABLE_LEGACY_INPUT_MANAGER
float m_CachedSmoothValue = 0.0f;
#endif

public override bool IsValid(VisualEffect component)
{
Expand Down
2 changes: 0 additions & 2 deletions ...y.visualeffectgraph/Runtime/Utilities/PropertyBinding/Implementation/VFXInputKeyBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ class VFXInputKeyBinder : VFXBinderBase
public float SmoothSpeed = 2.0f;
public bool UseKeySmooth = true;

#if ENABLE_LEGACY_INPUT_MANAGER
float m_CachedSmoothValue = 0.0f;
#endif

public override bool IsValid(VisualEffect component)
{
Expand Down