VFX 8.3 backports #2669

julienf-unity · 2020-11-18T11:59:18Z

Purpose of this PR

Backports of VFX to 8.3

Added

New WorldToViewportPoint operator
New ViewportToWorldPoint operator

Fixed

Debug material view were rendering pink for albedo. (case 1290752)
Fix for node window staying when clicking elsewhere
Prefab highlight missing for initial event name toggle Case 1263012
fix crash when creating a loop in subgraph operators Case 1251523
Make VisualEffect created from the GameObject menu have unique names Case 1262989
Normals with non uniform scales are correctly computed Case 1246989
Fix exposed Texture2DArray and Cubemap types from shader graph not being taken into account in Output Mesh Case 1265221
Optimize display of inspector when there is a lot of exposed VFX properties.
Correctly frame the whole graph, when opening the Visual Effect Editor
fix issue with multiselection and objectfields Case 1250378
GPU Evaluation of Construct Matrix
Random Per-Component on Set Attribute in Spawn Context Case 1279294
Fix corrupted UI in nodes due to corrupted point cache files Case 1232867
Fix InvalidCastException when using byte properties in point cache files Case 1276623
Fix shadows not being rendered to some cascades with directional lights Case 1229972
Fix Case 1114281
Fix Case 1268354
Forbid creation of context in VisualEffectSubgraphBlock through edge dropping. No context should be allowed.
Fix Case 1281861
Unexpected exception while installing samples inside an URP project Case 1280065
Fix Case 1219072
Fix Case 1211372
Fix Case 1262961
Fix Case 1199540
Fix VFX Graph window invalidating existing Undo.undoRedoPerformed delegates.
Fix for VisualEffect prefab override window Case 1242693
Fix edited operator being collapsed Case 1270517
"Create new VisualEffect Graph" creates a graph from the default template Case 1279999
Property Binder : Incorrect Destroy called from edit mode. Case 1274790
Property Binder : Unexpected null reference exception while using terrain binder. Case 1247230
Property Binder : HierarchyRoot null reference exception while using Hierarchy to Attribute Map. Case 1274788
Property Binder : Properties window isn't always up to date. Case 1248711
Property Binder : Avoid Warning while building on Mobile "Presence of such handlers might impact performance on handheld devices." when building for Android" Case 1279471
Fix View Space Position is VFX Shadergraph Case 1285603
Fix Case 1268354
Fixed rare bug causing the vfx compilation to do nothing silently.
Fixed vfx compilation when a diffusion profile property is added to a vfx shadergraph
Fix Case 1255182
Fix multiple undos Case 1262133

Testing status

Tested locally. All tests passed

Comments to reviewers

Notes for the reviewers you have assigned.

* Disable noperspective flag for driver issue on NDA platform * Add minor note to track the actual issue * Isolate on concerned platform * Change define condition

* Simplify linear drag * Fix warning

* Added system requirements documentation. * Corrected phrasing * Added toc entry * Reorganised toc entry Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

…ext (#76)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix missing type copy in reduce Tested locally on a PS4 * Add expection to detect unsupported value type

…text (#107)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r) An extra trailing new line character was causing an invalid offset in binary point cache files. * Update Changelog * Remove unnecessary files

…les (#109) * Change casting to byte We were trying to cast an object containing a byte to an int. Also, a better normalization would be dividing by 255. * Update CHANGELOG.md

…158)

This reverts commit 84ad80d.

* Override VFXPropertyAttribute equals to make it correct. * Update CHANGELOG.md

…sm (#63) * fix 8.x.x/vfx/sugraphoperator compile loop * Update VFXSubgraphOperator.cs

…staging

PaulDemeulenaere

I went through all changes, looks good to me.

VladNeykov

[Win] Smoke test, no issues found.
FTP project runs as expected, verified WorldToViewportPoint and ViewportToWorldPoint operators work, tried the manual test case for any weird glitches (collapse operators, gradient, curve, visual regressions, etc.) and creating new VFX.

Wrong backport from #2669

iTris666 and others added 30 commits November 16, 2020 15:52

Fix for blackboard scrollable element hidden by resize.

a877225

Target Gameobject windows resize doesn't go too far above scrollbars

b06e41f

e3ba0e6 - Missing or incorrect unit in uss.

021e108

[VFX] Fix crash on NDA platform : 100_Fog (#1265)

e0c8262

* Disable noperspective flag for driver issue on NDA platform * Add minor note to track the actual issue * Isolate on concerned platform * Change define condition

Simplify linear drag (#67)

02ac3a0

* Simplify linear drag * Fix warning

Vfx/docs/system requirements (#69)

76f6988

* Added system requirements documentation. * Corrected phrasing * Added toc entry * Reorganised toc entry Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

Fix for node window staying when clicking elsewhere #68

b8f4cf0

Prevent resourcehistory from beeing set to null by serialization (#66)

8016314

Fix position of block creation window (#72)

f1c5f97

Fix Prefab Highlight for initial event name toggle & override #71

361f721

Call recreateCopy after recusion test not before. #52

19e3fba

Uniquify create visual effect gameobject name. Standard behaviour. #75

057457f

Vfx/fix/1246989 normals and scale (#81)

7e595fe

Fix Texture2DArray and Cubemap exposition from sg in output mesh cont…

1f08958

…ext (#76)

int and uint support in Compare (#53)

b7b8af8

Added render pipeline compatability table (#87)

ca964cc

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

Fix square complexity on parameter to serialized property matching

8cf1ae2

Fix vfx view not beeing framed at launch

a1ebfe3

Fix for the lookup of mixed values in the VisualEffectEditor with obj…

d449a5a

SampleSDF operator (#88)

fdff963

Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

84ad80d

* Fix missing type copy in reduce Tested locally on a PS4 * Add expection to detect unsupported value type

Fix 1154328 - infinite recompile with rand (#93)

0dbb605

World to Viewport Point & Viewport to World Point operators + Test (#98)

8436069

Fix Construct Matrix on GPU (#102)

241fa27

Remove Debug Log

1283c9a

Fix case 1279294 : Invalid Random per component behavior in spawn con…

ffd1156

…text (#107)

Fix InvalidCastException when using byte properties in point cache fi…

08aebc3

…les (#109) * Change casting to byte We were trying to cast an object containing a byte to an int. Also, a better normalization would be dividing by 255. * Update CHANGELOG.md

Setting ZClip in shadow caster templates (#99)

65a2287

Fix and reenable test (#117)

7be875a

julienf-unity and others added 17 commits November 16, 2020 17:34

Fix subgraph not being sanitized at import

4b88413

[HDRP] Fix debug view material (albedo/normal/...)

79b853d

Force ui update when shader might be reimported in StaticMeshOutput (#…

b551611

…158)

Revert "Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)"

675cdff

This reverts commit 84ad80d.

Fix compil

b65344c

Backout int and uint support in Compare (#53)

59c7a6f

Override VFXPropertyAttribute equals to make it correct. (#73)

ebb4e52

* Override VFXPropertyAttribute equals to make it correct. * Update CHANGELOG.md

8.x.x Fix compile loop in vfxoperator by adding a RecreateCopy mecani…

2c3cf3d

…sm (#63) * fix 8.x.x/vfx/sugraphoperator compile loop * Update VFXSubgraphOperator.cs

Fix changelog

323b005

Merge remote-tracking branch 'graphics/8.x.x/release' into vfx/8.x.x-…

4eb1a55

…staging

backout SampleSDF operator (#88)

d46ea8a

Fix some tests (8 and 26)

faff67d

Update HDRP VFX + meta

c9de33c

Update URP project + add missing metas

31aef98

*Update HDRP_Debug considering the blending is enable for debug material

8ec1abc

*Add missing standalone 28_CameraProject.png

f8c9d5d

*Increase treshold for 26_NonUnifomScale.unity

5adf5c9

julienf-unity requested review from PaulDemeulenaere and VladNeykov November 18, 2020 11:59

julienf-unity added HDRP vfx labels Nov 18, 2020

julienf-unity requested a review from sebastienlagarde November 18, 2020 16:45

PaulDemeulenaere approved these changes Nov 18, 2020

View reviewed changes

VladNeykov approved these changes Nov 18, 2020

View reviewed changes

sebastienlagarde approved these changes Nov 18, 2020

View reviewed changes

Merge branch '8.x.x/release' into vfx/8.x.x-staging

be4b0dc

sebastienlagarde merged commit fbcd094 into 8.x.x/release Nov 18, 2020

sebastienlagarde deleted the vfx/8.x.x-staging branch November 18, 2020 22:28

PaulDemeulenaere added a commit that referenced this pull request Dec 5, 2020

Revert unexpected change in IntputButtonBinders

0acaab2

Wrong backport from #2669

PaulDemeulenaere mentioned this pull request Dec 5, 2020

[8.x.x] [VFX] Fix Compilation with old input system (1297444) #2857

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

VFX 8.3 backports #2669

VFX 8.3 backports #2669

Uh oh!

julienf-unity commented Nov 18, 2020

Uh oh!

PaulDemeulenaere left a comment

Uh oh!

VladNeykov left a comment

Uh oh!

Uh oh!

VFX 8.3 backports #2669

VFX 8.3 backports #2669

Uh oh!

Conversation

julienf-unity commented Nov 18, 2020

Purpose of this PR

Added

Fixed

Testing status

Comments to reviewers

Uh oh!

PaulDemeulenaere left a comment

Choose a reason for hiding this comment

Uh oh!

VladNeykov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!