This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Group download notifications + remove seekbar #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbsurdlySuspicious
force-pushed
the
down_notif/feature
branch
from
9af15a5
to
5a98fb3
Compare
AbsurdlySuspicious
force-pushed
the
down_notif/feature
branch
from
5a98fb3
to
938ab3f
Compare
|
+ workaround for android 11 - see #282 |
Tunous
suggested changes
Jul 26, 2020
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| // --- | ||
| // Android 11 finally broke this so we'll force it to use BigPicture style for now | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && Build.VERSION.SDK_INT < 30) { |
There was a problem hiding this comment.
Can we use named version code here instead of 30? Perhaps with <= if latest is not available.
There was a problem hiding this comment.
SDK 28 is used so latest version listed there is api 28 / Android 9. I think the only way to get new consts is to unlink compileSdk and targetSdk in gradle scripts and switch to compile 30 + target 28. This way it shouldn't break anything, though sdk update is entirely different matter anyway
There was a problem hiding this comment.
Ok I see, lets leave this as is then.
Tunous
approved these changes
Jul 26, 2020
msfjarvis
added a commit
to msfjarvis/Dawn
that referenced
this pull request
Aug 1, 2020
…/androidx.room-room-rxjava2-2.2.5 * upstream/master: Add downloaded files to media index (Tunous#288) Group download notifications + remove seekbar (Tunous#285) Use Instant in recycling unit test
Tunous
added a commit
that referenced
this pull request
Aug 1, 2020
* Use Instant in recycling unit test * Group download notifications + remove seekbar (#285) * remove seekbar * group download notifications * put success notifications in a separate group * changelog * workaround for Android 11 Co-authored-by: Łukasz Rutkowski <lukus178@gmail.com> * Add downloaded files to media index (#288) * index new media * update already downloaded media * properly broadcast video files * force downloaded media rescan * changelog * build: commonize room version Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Fix tests Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Revert "Fix tests" This reverts commit 4778981. Co-authored-by: Łukasz Rutkowski <lukus178@gmail.com> Co-authored-by: AbsurdlySuspicious <absurdlysuspicious@protonmail.com>
Tunous
added a commit
that referenced
this pull request
Aug 1, 2020
* Bump room-rxjava2 from 2.2.1 to 2.2.5 Bumps room-rxjava2 from 2.2.1 to 2.2.5. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fixes for #170 (#289) * Use Instant in recycling unit test * Group download notifications + remove seekbar (#285) * remove seekbar * group download notifications * put success notifications in a separate group * changelog * workaround for Android 11 Co-authored-by: Łukasz Rutkowski <lukus178@gmail.com> * Add downloaded files to media index (#288) * index new media * update already downloaded media * properly broadcast video files * force downloaded media rescan * changelog * build: commonize room version Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Fix tests Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Revert "Fix tests" This reverts commit 4778981. Co-authored-by: Łukasz Rutkowski <lukus178@gmail.com> Co-authored-by: AbsurdlySuspicious <absurdlysuspicious@protonmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Łukasz Rutkowski <lukus178@gmail.com> Co-authored-by: AbsurdlySuspicious <absurdlysuspicious@protonmail.com> Co-authored-by: Łukasz Rutkowski <Tunous@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable grouping of successful media download notifications.
Also remove seekbar so that they look normal on Android >=9