This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
forked from saket/Dank
-
Notifications
You must be signed in to change notification settings - Fork 36
Group download notifications + remove seekbar #285
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
272ba56
remove seekbar
AbsurdlySuspicious 1e79cb8
group download notifications
AbsurdlySuspicious 4e4ca07
put success notifications in a separate group
AbsurdlySuspicious 938ab3f
changelog
AbsurdlySuspicious f61a8d2
workaround for Android 11
AbsurdlySuspicious 769cc9f
Merge branch 'master' into down_notif/feature
Tunous File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use named version code here instead of
30
? Perhaps with<=
if latest is not available.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDK 28 is used so latest version listed there is api 28 / Android 9. I think the only way to get new consts is to unlink compileSdk and targetSdk in gradle scripts and switch to compile 30 + target 28. This way it shouldn't break anything, though sdk update is entirely different matter anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I see, lets leave this as is then.