Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Download notifications misuses the media notification #282

Open
cccClyde opened this issue Jul 24, 2020 · 6 comments
Open

Download notifications misuses the media notification #282

cccClyde opened this issue Jul 24, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@cccClyde
Copy link

Image downloading in Dawn is using the media notification (or it is recognized as media notification), thus on Android 11 there's no notification at all after download completed (because the media control redesign).

Just download any images in app to reproduce it. Can confirm it because on OneUI based on Android 10, the notification style is just like other music players'.

photo_2020-07-19_19-46-49

@cccClyde cccClyde added the bug Something isn't working label Jul 24, 2020
@saket
Copy link

saket commented Jul 25, 2020

This was a good hack while it worked

@AbsurdlySuspicious
Copy link
Collaborator

This is also probably why they're not stacking together starting from 3rd notification

@cccClyde
Copy link
Author

This was a good hack while it worked

A hack for what exactly? If it's for the image preview, there seems to be a better solution by using the expandable notification. The final outcome should look like the screenshot notifications on Android. Not as pretty as media notifications but it jut works 🌚

@AbsurdlySuspicious
Copy link
Collaborator

AbsurdlySuspicious commented Jul 25, 2020

It work as it currently is too :)

Well, I think there should be a way to keep current looks and get rid of mentioned issues

@AbsurdlySuspicious
Copy link
Collaborator

It work as it currently is too :)

Sorry, I misread the part about notification being completely invisible on android 11.
To keep current looks it should probably be reworked as fully custom notification

@AbsurdlySuspicious
Copy link
Collaborator

I've added fallback to BigPictureStyle notifications for Android 11 to #285. That should work for now, however, I think this issue should stay open until better solution comes up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants