Skip to content

bugfix(ui): fix incorrect hijack hint when multiple units are selected #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SoleimanyBen wants to merge 1 commit into from
+5 −1
Closed

bugfix(ui): fix incorrect hijack hint when multiple units are selected #2006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2869,7 +2869,11 @@ void InGameUI::createCommandHint( const GameMessage *msg )
case GameMessage::MSG_CONVERT_TO_CARBOMB_HINT:
case GameMessage::MSG_HIJACK_HINT:
case GameMessage::MSG_SABOTAGE_HINT:
setMouseCursor( Mouse::ENTER_AGGRESSIVELY );
// TheSuperHackers @bugfix soleimanyben 12/18/2025 Fixes an issue where the hijack hint was shown instead of the attack hint when multiple units are selected.
Copy link

@Caball009 Caball009 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18/12/2025

if ( getSelectCount() == 1 )
Copy link

@Stubbjax Stubbjax Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem right. What if the player has two Hijackers selected? Then it won't show the enter cursor?

setMouseCursor( Mouse::ENTER_AGGRESSIVELY );
else
setMouseCursor( Mouse::ATTACK_OBJECT );
break;
case GameMessage::MSG_DEFECTOR_HINT:
setMouseCursor( Mouse::DEFECTOR );
Expand Down