bugfix(ui): fix incorrect hijack hint when multiple units are selected #2006
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caball009
reviewed
Dec 19, 2025
| case GameMessage::MSG_HIJACK_HINT: | ||
| case GameMessage::MSG_SABOTAGE_HINT: | ||
| setMouseCursor( Mouse::ENTER_AGGRESSIVELY ); | ||
| // TheSuperHackers @bugfix soleimanyben 12/18/2025 Fixes an issue where the hijack hint was shown instead of the attack hint when multiple units are selected. |
Caball009
requested changes
Dec 19, 2025
Caball009
left a comment
Caball009
left a comment
There was a problem hiding this comment.
It seems to me this doesn't need fixing or is incomplete. I made a post in the issue report addressing this point.
Stubbjax
reviewed
Dec 19, 2025
| case GameMessage::MSG_SABOTAGE_HINT: | ||
| setMouseCursor( Mouse::ENTER_AGGRESSIVELY ); | ||
| // TheSuperHackers @bugfix soleimanyben 12/18/2025 Fixes an issue where the hijack hint was shown instead of the attack hint when multiple units are selected. | ||
| if ( getSelectCount() == 1 ) |
There was a problem hiding this comment.
This does not seem right. What if the player has two Hijackers selected? Then it won't show the enter cursor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1955
Unsure if a simple length check is the appropriate fix here, but it does seem to resolve the issue.