[GEN][ZH] Prevent duplicate replays from being shown in the Replay Menu #1208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
Lines 213 to 227 in 7e18d29
The current logic to show the list of replay files is divided into two parts. First it collects all replay files, and then it attempts to open any found replay files. The former searches all sub directories, but the latter uses only the replay file name and tries to open the file from the base directory.
Considering the following directory layout, GR2 isn't shown but GR1 is shown twice even if the second file is different or empty:
This PR disables the search in sub directories.