Fix interpolated second shot #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/frc/robot/subsystems/FlywheelSubsystem.java
Need more data
…oting-interpolation
|
This branches off shooting-interpolation branch |
|
So, what does this commit do exactly? I'm confused why we need to keep the distance value for the second ball |
…nd-shot # Conflicts: # src/main/java/frc/robot/RobotContainer.java
|
adityapawar1
previously approved these changes
Apr 17, 2022
| @@ -170,7 +155,7 @@ public boolean isFinished() { | |||
|
|
|||
| @Override | |||
| public void initialize() { | |||
| Limelight.enable(); | |||
| // Limelight.enable(); | |||
There was a problem hiding this comment.
Limelight will be on for the whole match because it reduces the time it takes for the robot to think its tracking the target. Because of the delay, it start doing odometry auto align which shakes the robot a little bit and makes the shots less accurate
…DVelocityFromState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
I have read the Contributing document.
If code changes were made then they have been tested.