-
-
Notifications
You must be signed in to change notification settings - Fork 394
fix(ffmpeg): remove redundant log statement #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was curious why this wasn't caught before because I swear that I see valid FFmpeg location logs each time on startup, and then I noticed why - this log statement is redundant and doesn't even need to be here in the first place. Two log statements in 2025-03-07 11:43:18 [info ] [FFMPEG] Using FFprobe location: ffprobe
2025-03-07 11:43:18 [info ] [FFMPEG] Using FFmpeg location: ffmpeg |
fair point, it's gone now |
I apologize for the inconvenience, #844 has now been pulled and a rebase targeting Thank you for your work on this, and sorry again for the disruption! |
97dc72b
to
d930b6b
Compare
d930b6b
to
8a53672
Compare
rebase is done |
Actually, are we sure the log is redundant? In testing an environment without FFmpeg, I still get these two log statements, I do not think they actually say FFmpeg is present, but rather that it is being tested:
Later on, I suppose after the check is done, there is this statement (after fixing the format string):
|
You're right that the original log statement doesn't indicate whether or not it was found or not. However, the underlying code is capable of it and the ffmpeg_checker should be using that backend code (or expanding upon it) instead of being a combination of frontend and backend code that also circumvents fixes done in #436. Overall this is unfortunately just a "tip of the iceberg" issue with some more explanation now in #854 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be merging this into a new branch to use as the basis for a greater set of fixes and refactors involving this corner of the codebase. Thank you for the initial find and work on this!
* fix: remove log statement as it is redundant (#840) * refactor: rework ffmpeg_checker.py Move backend logic from ffmpeg_checker.py to vendored/ffmpeg.py, add translation strings for ffmpeg_checker, update vendored/ffmpeg.py * fix: stop ffmpeg cmd windows, fix version outputs * chore: ensure stdout is cast to str --------- Co-authored-by: Jann Stute <46534683+Computerdores@users.noreply.github.com>
Summary
A string for a log message was missing the
f
to make it a format string.Tasks Completed