Skip to content

fix: stop ffmpeg cmd windows, refactor ffmpeg_checker #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Conversation

CyanVoxel
Copy link
Member

Summary

This PR fixes numerous issues with the ffmpeg_checker.py file. Fixes #854.

Changes

  • Stop showing several CMD window popups on Windows builds when opening the "About TagStudio" screen
  • Show correct FFmpeg and FFprobe version text, notably for nightly builds
  • Refactor ffmpeg-checker.py:
    • Remove backend logic from this UI class
    • Remove duplicated logic
    • Only instantiate class if necessary, not every time on startup
    • In the version check (now moved to vendored/ffmpeg), use consistent logic and remove (suspiciously bizarre) flags and string processing steps
    • Add missing translation strings

Example of correct version readouts on Windows 10:
ffmpeg_version_fix_win

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

Computerdores and others added 4 commits March 10, 2025 19:17
Move backend logic from ffmpeg_checker.py to vendored/ffmpeg.py, add translation strings for ffmpeg_checker, update vendored/ffmpeg.py
@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Refactor Code that needs to be restructured or cleaned up Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed labels Mar 11, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 11, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Mar 11, 2025
@CyanVoxel CyanVoxel added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed labels Mar 17, 2025
@CyanVoxel CyanVoxel merged commit 880ca07 into main Mar 20, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 🏓 Ready for Review to ✅ Done in TagStudio Development Mar 20, 2025
@CyanVoxel CyanVoxel deleted the fix-854 branch March 20, 2025 08:09
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Bug Something isn't working as intended Type: Refactor Code that needs to be restructured or cleaned up Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Refectoring FFmpegChecker
2 participants