Description
Right now, the FFmpegChecker
is a class that’s inherited from QMessageBox
and the installed()
function is one of its methods. this means you have to create an instance of FFmpegChecker
just to check if FFmpeg is installed. which isn’t ideal because you don’t actually need to set up the UI element if FFmpeg is already there. also in ts_qt.py
the FFmpegChecker
instance is stored as a class variable. so that one time message box sticks around for the entire time the app is running. this could be cleaned up with some refactoring. if this makes sense, let me know so that i can start working on it. if it’s not a big deal, we can just close this issue.
if it’s alright to refactor, should the app freeze (block) when the message box shows up? also should the message box pop up every time the app starts, just once, or maybe have a ‘Don’t show again’ checkbox like most apps do? what do you think?
Metadata
Metadata
Assignees
Labels
Type
Projects
Status