Skip to content

fix: shut up mypy #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2024
Merged

fix: shut up mypy #609

merged 5 commits into from
Nov 28, 2024

Conversation

Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Nov 28, 2024 •
edited
Loading

Just four extremly short fixes in order to stop mypy from complaining constantly. Specifically:

  • two type ignore comments threw unused-ignore on windows (but didn't on linux), the type ignores now also ignore unused-ignore
  • a call in ts_qt was missing a trivial argument
  • two variables in file_opener had the same name but different type and mypy wasn't happy about that, I renamed one appropriately

@CyanVoxel
Copy link
Member

The preview_panel.py one I finally snuffed out in #608, but these should be some much welcomed fixes 👍

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: CI Continuous Integration / workflows Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed System: Windows For Microsoft Windows System: macOS For the macOS operating system labels Nov 28, 2024
@CyanVoxel CyanVoxel added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed labels Nov 28, 2024
@CyanVoxel CyanVoxel merged commit 20f9371 into TagStudioDev:main Nov 28, 2024
5 checks passed
@Computerdores Computerdores mentioned this pull request Nov 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees
No one assigned
Labels
Priority: Medium An issue that shouldn't be be saved for last Status: Mergeable The code is ready to be merged System: macOS For the macOS operating system System: Windows For Microsoft Windows Type: Bug Something isn't working as intended Type: CI Continuous Integration / workflows Type: QoL A quality of life (QoL) enhancement or suggestion
Projects
TagStudio Development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Computerdores @CyanVoxel