Skip to content

Commit 20f9371

Browse files
fix(ci): surpress errant mypy warnings (#609)
* fix: mypy error in ts_qt * fix: mypy error in file_opener due to conflicting types * fix: remove unnecessary type ignores * refix type ignore comments * partially revert "refix type ignore comments" due to being implemented in #608
1 parent 262893a commit 20f9371

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

tagstudio/src/qt/helpers/file_opener.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ def open_file(path: str | Path, file_manager: bool = False):
3434
normpath = Path(path).resolve().as_posix()
3535
if file_manager:
3636
command_name = "explorer"
37-
command_args = '/select,"' + normpath + '"'
37+
command_arg = '/select,"' + normpath + '"'
3838
# For some reason, if the args are passed in a list, this will error when the
3939
# path has spaces, even while surrounded in double quotes.
4040
subprocess.Popen(
41-
command_name + command_args,
41+
command_name + command_arg,
4242
shell=True,
4343
close_fds=True,
4444
creationflags=subprocess.CREATE_NEW_PROCESS_GROUP

tagstudio/src/qt/ts_qt.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ def start(self) -> None:
254254

255255
if os.name == "nt":
256256
appid = "cyanvoxel.tagstudio.9"
257-
ctypes.windll.shell32.SetCurrentProcessExplicitAppUserModelID(appid) # type: ignore
257+
ctypes.windll.shell32.SetCurrentProcessExplicitAppUserModelID(appid) # type: ignore[attr-defined,unused-ignore]
258258

259259
if sys.platform != "darwin":
260260
icon = QIcon()
@@ -823,6 +823,7 @@ def run_macro(self, name: MacroID, grid_idx: int):
823823
if field.type.type == FieldTypeEnum.TEXT_LINE and field.value:
824824
self.lib.update_entry_field(
825825
entry_ids=entry.id,
826+
field=field,
826827
content=strip_web_protocol(field.value),
827828
)
828829

0 commit comments

Comments
 (0)